You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/31 14:42:21 UTC

[GitHub] [hadoop-ozone] flirmnave opened a new pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

flirmnave opened a new pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368


   ## What changes were proposed in this pull request?
   
   Add hierarchical layout to Chinese doc
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4156
   
   ## How was this patch tested?
   
   Test on local use hugo server.
   ![Screenshot from 2020-08-31 22-40-19](https://user-images.githubusercontent.com/2565172/91732692-2804f480-ebdb-11ea-860a-a3c8b325f552.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] iamabug commented on a change in pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
iamabug commented on a change in pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#discussion_r480992755



##########
File path: hadoop-hdds/docs/content/concept/_index.zh.md
##########
@@ -2,7 +2,7 @@
 title: 概念
 date: "2017-10-10"
 menu: main
-weight: 6
+weight: 3

Review comment:
       No, it is the right thing to do, sorry for not noticing this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cku328 commented on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
cku328 commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-697277442


   Overall LGTM. Thanks @flirmnave for working on this.
   This PR will make the Chinese docs more friendly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] flirmnave commented on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
flirmnave commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-684447642


   > Thanks for the work @flirmnave .
   > 
   > According to what I see in localhost, it seems there are some subpages left.
   > 
   > ![](https://camo.githubusercontent.com/0f4b4bf694439930b0ac7d53e0cb5247ee5b6405/68747470733a2f2f747661312e73696e61696d672e636e2f6c617267652f30303753385a496c6c7931676961777364656565786a3330673231316f7135752e6a7067)
   > 
   > Also, as for `Features` menu, I think it is both okay to finish it in a separate PR or in this one.
   
   
   Thanks @iamabug review and comment.
   Some of the documents have not been translated into Chinese
   So some subpages left.
   
   For `Features` menu, I have create a Jira issue.
   https://issues.apache.org/jira/browse/HDDS-4184


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek merged pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
elek merged pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] flirmnave commented on a change in pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
flirmnave commented on a change in pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#discussion_r480821571



##########
File path: hadoop-hdds/docs/content/concept/_index.zh.md
##########
@@ -2,7 +2,7 @@
 title: 概念
 date: "2017-10-10"
 menu: main
-weight: 6
+weight: 3

Review comment:
       Hi,
   I see that it weight 3 in english version.
   https://github.com/apache/hadoop-ozone/blame/master/hadoop-hdds/docs/content/concept/_index.md#L5
   So I change it, Should I change it back?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] cku328 removed a comment on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
cku328 removed a comment on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-697277442


   Overall LGTM. Thanks @flirmnave for working on this.
   This PR will make the Chinese docs more friendly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] iamabug commented on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
iamabug commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-684143623


   Thanks for the work @flirmnave .
   
   According to what I see in localhost, it seems there are some subpages left.
   
   ![](https://tva1.sinaimg.cn/large/007S8ZIlly1giawsdeeexj30g211oq5u.jpg)
   
   Also, as for `Features` menu, I think it is both okay to finish it in a separate PR or in this one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] flirmnave commented on a change in pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
flirmnave commented on a change in pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#discussion_r483637138



##########
File path: hadoop-hdds/docs/content/concept/_index.zh.md
##########
@@ -2,7 +2,7 @@
 title: 概念
 date: "2017-10-10"
 menu: main
-weight: 6
+weight: 3

Review comment:
       It’s ok.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-694532324


   LGTM overall. Only have one question: should move the GDPR under the Security not Features. This may apply to the original EN document as well. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] iamabug commented on a change in pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
iamabug commented on a change in pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#discussion_r480564649



##########
File path: hadoop-hdds/docs/content/concept/_index.zh.md
##########
@@ -2,7 +2,7 @@
 title: 概念
 date: "2017-10-10"
 menu: main
-weight: 6
+weight: 3

Review comment:
       Could you please explain the reason why `weight` is changed here? @flirmnave 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] flirmnave commented on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
flirmnave commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-703986323


   Thanks for @iamabug @xiaoyuyao @cku328 reviewing and @elek merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek commented on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-703633236


   Comments from @xiaoyuyao are addressed (issue is created) and @cku328 also reviewed it (thanks for both)
   
   I don't speak Mandarin well, but merging this now as structure change seems to be ok.
   
   Thanks the contribution @flirmnave 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] flirmnave commented on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

Posted by GitBox <gi...@apache.org>.
flirmnave commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-694857667


   > LGTM overall. Only have one question: should move the GDPR under the Security not Features. This may apply to the original EN document as well.
   
   Thanks @xiaoyuyao for the review and comment.
   I create a Jira issue [HDDS-4258](https://issues.apache.org/jira/browse/HDDS-4258) for move the GDPR under the Security.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org