[GitHub] [helix] pkuwm commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods
URL: https://github.com/apache/helix/pull/600#discussion_r346103137
 
 

 ##########
 File path: helix-core/pom.xml
 ##########
 @@ -159,6 +159,12 @@ under the License.
       <artifactId>metrics-core</artifactId>
       <version>3.2.3</version>
     </dependency>
+    <dependency>
+      <groupId>com.google.code.gson</groupId>
+      <artifactId>gson</artifactId>
+      <version>2.8.6</version>
 
 Review comment:
   If this version is supposed to be the same with the version in root pom.xml, this version number doesn't have to be specified here in sub module. It will automatically pick up the version which root pom.xml sets. I think this way would help maintain, ex. if we want to upgrade the version in the future. And FYI, I think helix is using Jackson in helix-rest. You can check it out. Would Jackson fit your use case ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org