[GitHub] rob05c commented on a change in pull request #2979: Fix TO Go DSS GET endpoints to check tenancy

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #2979: Fix TO Go DSS GET endpoints to check tenancy
URL: https://github.com/apache/trafficcontrol/pull/2979#discussion_r254027606
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go
 ##########
 @@ -142,7 +143,21 @@ func (dss *TODeliveryServiceServer) readDSS(tx *sqlx.Tx, user *auth.CurrentUser,
 		orderby = "deliveryService"
 	}
 
-	query, err := selectQuery(orderby, strconv.Itoa(limit), strconv.Itoa(offset))
+	tenancyEnabled, err := tenant.IsTenancyEnabledTx(tx.Tx)
 
 Review comment:
   I think we decided to do that, but I don't think we actually did. The code still checks `use_tenancy` everywhere, and I think it's considered false if it doesn't exist. 
   
   I think this because the API Tests until recently broke horribly if you created that Parameter, suggesting Tenancy is disabled by default.
   
   Also, I'm not opposed to making Tenancy "always on," but I do kind of think we should enable Capabilities at the same time (https://github.com/apache/trafficcontrol/pull/2791). Tenancy isn't really useful without Capabilities to limit what users can do, and it could be deceptive, a CDN operator might think tenancy limits an admin/ops user, when it doesn't.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services