You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "li4wang (via GitHub)" <gi...@apache.org> on 2025/05/16 19:46:04 UTC
[PR] ZOOKEEPER-4930: Add metrics for TTL node deletion [zookeeper]
li4wang opened a new pull request, #2261:
URL: https://github.com/apache/zookeeper/pull/2261
Author: Li Wang <li...@apple.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4930: Add metrics for TTL node deletion [zookeeper]
Posted by "li4wang (via GitHub)" <gi...@apache.org>.
li4wang merged PR #2261:
URL: https://github.com/apache/zookeeper/pull/2261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4930: Add metrics for TTL node deletion [zookeeper]
Posted by "li4wang (via GitHub)" <gi...@apache.org>.
li4wang commented on code in PR #2261:
URL: https://github.com/apache/zookeeper/pull/2261#discussion_r2122255903
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java:
##########
@@ -584,6 +584,7 @@ public void deleteNode(String path, long zxid) throws NoNodeException {
containers.remove(path);
} else if (ephemeralType == EphemeralType.TTL) {
ttls.remove(path);
+ ServerMetrics.getMetrics().TTL_NODE_DELETED_COUNT.add(1);
Review Comment:
This JIRA is for TTL deletion metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4930: Add metrics for TTL node deletion [zookeeper]
Posted by "li4wang (via GitHub)" <gi...@apache.org>.
li4wang commented on code in PR #2261:
URL: https://github.com/apache/zookeeper/pull/2261#discussion_r2122257305
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java:
##########
@@ -584,6 +584,7 @@ public void deleteNode(String path, long zxid) throws NoNodeException {
containers.remove(path);
} else if (ephemeralType == EphemeralType.TTL) {
ttls.remove(path);
+ ServerMetrics.getMetrics().TTL_NODE_DELETED_COUNT.add(1);
Review Comment:
@zeekling Opened a JIRA for TTL creation metrics.
https://issues.apache.org/jira/browse/ZOOKEEPER-4934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4930: Add metrics for TTL node deletion [zookeeper]
Posted by "zeekling (via GitHub)" <gi...@apache.org>.
zeekling commented on code in PR #2261:
URL: https://github.com/apache/zookeeper/pull/2261#discussion_r2152621523
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java:
##########
@@ -584,6 +584,7 @@ public void deleteNode(String path, long zxid) throws NoNodeException {
containers.remove(path);
} else if (ephemeralType == EphemeralType.TTL) {
ttls.remove(path);
+ ServerMetrics.getMetrics().TTL_NODE_DELETED_COUNT.add(1);
Review Comment:
> metrics
ok, great job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4930: Add metrics for TTL node deletion [zookeeper]
Posted by "li4wang (via GitHub)" <gi...@apache.org>.
li4wang commented on code in PR #2261:
URL: https://github.com/apache/zookeeper/pull/2261#discussion_r2122257305
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java:
##########
@@ -584,6 +584,7 @@ public void deleteNode(String path, long zxid) throws NoNodeException {
containers.remove(path);
} else if (ephemeralType == EphemeralType.TTL) {
ttls.remove(path);
+ ServerMetrics.getMetrics().TTL_NODE_DELETED_COUNT.add(1);
Review Comment:
@zeekling Opened a JIRA for TTL creation metrics.
https://issues.apache.org/jira/browse/ZOOKEEPER-4934
I can submit a PR for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4930: Add metrics for TTL node deletion [zookeeper]
Posted by "zeekling (via GitHub)" <gi...@apache.org>.
zeekling commented on code in PR #2261:
URL: https://github.com/apache/zookeeper/pull/2261#discussion_r2119274686
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java:
##########
@@ -584,6 +584,7 @@ public void deleteNode(String path, long zxid) throws NoNodeException {
containers.remove(path);
} else if (ephemeralType == EphemeralType.TTL) {
ttls.remove(path);
+ ServerMetrics.getMetrics().TTL_NODE_DELETED_COUNT.add(1);
Review Comment:
create Node need metrics alse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4930: Add metrics for TTL node deletion [zookeeper]
Posted by "zeekling (via GitHub)" <gi...@apache.org>.
zeekling commented on PR #2261:
URL: https://github.com/apache/zookeeper/pull/2261#issuecomment-2984450406
no problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4930: Add metrics for TTL node deletion [zookeeper]
Posted by "li4wang (via GitHub)" <gi...@apache.org>.
li4wang commented on PR #2261:
URL: https://github.com/apache/zookeeper/pull/2261#issuecomment-2981287818
@zeekling any objection to get this PR approved and merged?
I will submit a PR for TTL node creation metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org