You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/06 23:01:13 UTC
[GitHub] [arrow] ElenaHenderson opened a new pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables [WIP]
ElenaHenderson opened a new pull request #10667:
URL: https://github.com/apache/arrow/pull/10667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
ElenaHenderson commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r680105559
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+## Benchmark Builds Env
+This directory contains
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built from source
Review comment:
@bkietz Done. Please let me know if README.md makes sense to you about hooks are used by private repo and how they can be used by others. Will you please also approve CI workflow? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r679945382
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,209 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+# Benchmark Builds Env and Hooks
+This directory contains:
+- [benchmarks.env](benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/).
+- [hooks.sh](hooks.sh) - hooks used by <b>@ursabot</b> benchmark builds that are triggered by `@ursabot please benchmark` PR comments.
+
+## How to add or update Arrow build and run env vars used by `@ursabot` benchmark builds
+1. Create `apache/arrow` PR
+2. Update or add env var value in [benchmarks.env](../../dev/conbench_envs/benchmarks.env)
+3. Add `@ursabot please benchmark` comment to PR
+4. Once benchmark builds are done, benchmark results can be viewed via compare/runs links in the PR comment where
+- baseline = PR base HEAD commit with unaltered `/dev/conbench_envs/benchmarks.env`
+- contender = PR branch HEAD commit with overridden `/dev/conbench_envs/benchmarks.env`
+
+## Why do`@ursabot` benchmark builds need `hooks.sh`?
+`@ursabot` benchmark builds are maintained in Ursa's private repo.
+Benchmark builds use `hooks.sh` functions as hooks to create conda env with Arrow dependencies and build Arrow C++/Python/R/Java/JavaScript from source for a specific Arrow repo's commit.
+
+Defining hooks in Arrow repo allows benchmark builds for a specific Arrow commit to be always compatible with Arrow's files/scripts used for installing Arrow dependencies and building Arrow, assuming Arrow contributors will update `hooks.sh` when they make these changes to files/scripts used by functions in `hooks.sh`.
Review comment:
```suggestion
Defining hooks in Arrow repo allows benchmark builds for a specific commit to be
compatible with the files/scripts *in that commit* which are used for installing Arrow
dependencies and building Arrow. This allows Arrow contributors to asses the perfomance
implications of different build options, dependency versions, etc by updating
`hooks.sh`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
ElenaHenderson commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r679440291
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+## Benchmark Builds Env
+This directory contains
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built from source
+
+## How to add or update Arrow build and run env vars used by benchmark builds
+1. Create `apache/arrow` PR
+2. Update or add env var value in [benchmarks.env](../../dev/conbench_envs/benchmarks.env)
+3. Add `@ursabot please benchmark` comment to PR
+4. Once benchmark builds are done, benchmark results can be viewed via compare/runs links in the PR comment where
+- baseline = PR base HEAD commit with default (master branch version) `/dev/conbench_envs/benchmarks.env`
Review comment:
@bkietz Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz closed pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #10667:
URL: https://github.com/apache/arrow/pull/10667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r679467533
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+## Benchmark Builds Env
+This directory contains
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built from source
Review comment:
To be clear, I think `util.sh` has merit here; IIUC it represents a one button "build arrow for benchmarking" script which is definitely useful- and not just to conbench. I think consumption of `utils.sh` by other code (whether private or public) is not an issue here, so long as we clarify the interface we're providing and make it clear how a consumer can be wired up.
For example if the hypothetical project cenbonch happened to have similar requirements to conbench and wanted to reuse `benchmark.env` and `util.sh` it wouldn't be immediately obvious how. I'm *guessing* that the only entry point which conbench requires is `create_conda_env_with_arrow_python`, so a cenbonch developer could safely replace `build_arrow_cpp, build_arrow_r, ...` with a monolithic `build_arrow` if that were useful for some reason and `@ursabot benchmark please` would continue to work. However without an explicit statement of ground rules for what should and shouldn't be in `util.sh` I'd have to infer it through trial and error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#issuecomment-875137555
https://issues.apache.org/jira/browse/ARROW-11691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
ElenaHenderson commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r679443134
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+## Benchmark Builds Env
+This directory contains
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built from source
Review comment:
@bkietz Thank you for the review. I added comments that I hope will make it clear why Arrow has`utils.sh`.
Note that I was not too confident about adding `utils.sh` (hooks used by benchmark builds managed in private repo) to this PR. I think it will help with benchmark builds/Arrow code compatibility issues we ran a few times. I added it to this PR because I wanted to see what Arrow contributors think about or if they have better solutions in mind.
If you think `utils.sh` is a not a good solution or it should not have been handled in this PR (which is only for `benchmarks.env`), I can remove it completely or handle in different PR. Please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r679234610
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+## Benchmark Builds Env
+This directory contains
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built from source
+
+## How to add or update Arrow build and run env vars used by benchmark builds
+1. Create `apache/arrow` PR
+2. Update or add env var value in [benchmarks.env](../../dev/conbench_envs/benchmarks.env)
+3. Add `@ursabot please benchmark` comment to PR
+4. Once benchmark builds are done, benchmark results can be viewed via compare/runs links in the PR comment where
+- baseline = PR base HEAD commit with default (master branch version) `/dev/conbench_envs/benchmarks.env`
Review comment:
```suggestion
- baseline = PR base HEAD commit with unaltered `/dev/conbench_envs/benchmarks.env`
```
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+## Benchmark Builds Env
+This directory contains
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built from source
Review comment:
I'm confused here because I don't see any usage of the functions in this script within arrow. If this is providing hooks for later use by conbench, could you include a reference to the relevant conbench issue which will add that usage? If util.sh is only meant to be illustrative for users who want to use `benchmarks.env` to produce an arrow build, could you clarify that intent here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
ElenaHenderson commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r680105559
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+## Benchmark Builds Env
+This directory contains
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built from source
Review comment:
@bkietz Done. Please let me know if README.md makes sense to you about why and how hooks are used by Ursa's private repo and how they can be used by others. Will you please also approve CI workflow? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables [WIP]
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r676750312
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,25 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+# TODO:
Review comment:
@ElenaHenderson will you address these in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables [WIP]
Posted by GitBox <gi...@apache.org>.
ElenaHenderson commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r676814202
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,25 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+# TODO:
Review comment:
@bkietz Yes, I will be addressing all TODOs in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
ElenaHenderson commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r679492792
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+## Benchmark Builds Env
+This directory contains
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built from source
Review comment:
@bkietz I will define ground rules. Give me 24 hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables
Posted by GitBox <gi...@apache.org>.
ElenaHenderson commented on a change in pull request #10667:
URL: https://github.com/apache/arrow/pull/10667#discussion_r680129299
##########
File path: dev/conbench_envs/README.md
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+## Benchmark Builds Env
+This directory contains
+- [benchmarks.env](../../dev/conbench_envs/benchmarks.env) - list of env vars used for building Arrow C++/Python/R/Java/JavaScript and running benchmarks using [conbench](https://ursalabs.org/blog/announcing-conbench/)
+- [utils.sh](../../dev/conbench_envs/utils.sh) - utils used by benchmark builds for creating conda env with Arrow C++/Python/R/Java/JavaScript built from source
Review comment:
@bkietz Thank you so much for the review.
I also added this comment. I hope it is ok.
`- benchmark builds are run using `@ursabot please benchmark` PR comment to confirm that function definition updates do not break benchmark builds.`.
https://github.com/apache/arrow/pull/10667/files#diff-04649ad45f96fd68437c83c30ad9dd25df8f6cf865d2a799b860eb7a159e11fcR47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org