You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/05/09 19:16:50 UTC
Review Request 59078: Fixed the MULTI_ROLE upgrade path for an old
master and new agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59078/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Bugs: MESOS-7478
https://issues.apache.org/jira/browse/MESOS-7478
Repository: mesos
Description
-------
The agent was accidentally assuming that the task sent by the master
had the `allocation_info` set. The fix is for `getExecutorInfo` to
inject only in the case where it is already set.
Diffs
-----
src/slave/slave.cpp a37c6c888e7573209aadb07576cfb727fa1ec4ff
Diff: https://reviews.apache.org/r/59078/diff/1/
Testing
-------
Manually performed upgrade tests:
1.2.0 agent with 1.1.0 master, crashes as MESOS-7478
HEAD+fix with 1.1.0 master, works
1.2.x+fix with 1.1.0 master, works
1.1.0 master with 1.1.0 agent, then upgrade agent to 1.2.x+fix works
Thanks,
Benjamin Mahler
Re: Review Request 59078: Fixed the MULTI_ROLE upgrade path for an old
master and new agent.
Posted by Benjamin Mahler <bm...@apache.org>.
> On May 9, 2017, 8:49 p.m., Michael Park wrote:
> > src/slave/slave.cpp
> > Line 4997 (original), 4997-4998 (patched)
> > <https://reviews.apache.org/r/59078/diff/1/?file=1711711#file1711711line4997>
> >
> > Maybe mention here that if the task does not have an allocation role, both `ExecutorInfo` and `TaskInfo` will have the allocation role injected later?
Sounds good.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59078/#review174372
-----------------------------------------------------------
On May 9, 2017, 7:16 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59078/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 7:16 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-7478
> https://issues.apache.org/jira/browse/MESOS-7478
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The agent was accidentally assuming that the task sent by the master
> had the `allocation_info` set. The fix is for `getExecutorInfo` to
> inject only in the case where it is already set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a37c6c888e7573209aadb07576cfb727fa1ec4ff
>
>
> Diff: https://reviews.apache.org/r/59078/diff/1/
>
>
> Testing
> -------
>
> Manually performed upgrade tests:
>
> 1.2.0 agent with 1.1.0 master, crashes as MESOS-7478
> HEAD+fix with 1.1.0 master, works
> 1.2.x+fix with 1.1.0 master, works
> 1.1.0 master with 1.1.0 agent, then upgrade agent to 1.2.x+fix works
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 59078: Fixed the MULTI_ROLE upgrade path for an old
master and new agent.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59078/#review174372
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
Line 4997 (original), 4997-4998 (patched)
<https://reviews.apache.org/r/59078/#comment247498>
Maybe mention here that if the task does not have an allocation role, both `ExecutorInfo` and `TaskInfo` will have the allocation role injected later?
- Michael Park
On May 9, 2017, 12:16 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59078/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 12:16 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-7478
> https://issues.apache.org/jira/browse/MESOS-7478
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The agent was accidentally assuming that the task sent by the master
> had the `allocation_info` set. The fix is for `getExecutorInfo` to
> inject only in the case where it is already set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a37c6c888e7573209aadb07576cfb727fa1ec4ff
>
>
> Diff: https://reviews.apache.org/r/59078/diff/1/
>
>
> Testing
> -------
>
> Manually performed upgrade tests:
>
> 1.2.0 agent with 1.1.0 master, crashes as MESOS-7478
> HEAD+fix with 1.1.0 master, works
> 1.2.x+fix with 1.1.0 master, works
> 1.1.0 master with 1.1.0 agent, then upgrade agent to 1.2.x+fix works
>
>
> Thanks,
>
> Benjamin Mahler
>
>