[GitHub] [buildstream] juergbi commented on a change in pull request #1533: Support creation of /dev/shm in the sandbox

[GitBox <gi...@apache.org>]

juergbi commented on a change in pull request #1533:
URL: https://github.com/apache/buildstream/pull/1533#discussion_r742636627



##########
File path: tests/integration/project/elements/sandbox-bwrap/build-dev-shm-not-mounted.bst
##########
@@ -0,0 +1,11 @@
+kind: manual
+
+depends:
+- base.bst
+
+config:
+  create-dev-shm: false
+
+  build-commands:
+  - |
+    mountpoint -q /dev/shm || true

Review comment:
       This will always succeed. To ensure it's not mounted we need something like:
   ```! mountpoint -q /dev/shm```

##########
File path: tests/integration/project/elements/sandbox-bwrap/script-dev-shm-not-mounted.bst
##########
@@ -0,0 +1,11 @@
+kind: script
+
+build-depends:
+- base.bst
+
+config:
+  create-dev-shm: false
+
+  commands:
+  - |
+    mountpoint -q /dev/shm || true

Review comment:
       Same here, this will always succeed. To ensure it's not mounted we need something like:
   ```! mountpoint -q /dev/shm```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org