You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/04/10 15:24:02 UTC

[GitHub] [beam] damccorm opened a new pull request, #26202: Allow multi_process_shared objects to be called

damccorm opened a new pull request, #26202:
URL: https://github.com/apache/beam/pull/26202

   This will allow things like models that are invoked via `model(args*)` to work.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1516297698

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @AnandInguva for label python.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1503366318

   Run Python_Integration PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on a diff in pull request #26202: Allow multi_process_shared objects to be called

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #26202:
URL: https://github.com/apache/beam/pull/26202#discussion_r1174502512


##########
sdks/python/apache_beam/utils/multi_process_shared.py:
##########
@@ -126,6 +134,24 @@ class _SingletonRegistrar(multiprocessing.managers.BaseManager):
     callable=_process_level_singleton_manager.release_singleton)
 
 
+# By default, objects registered with BaseManager.register will have only
+# public methods available (excluding __call__). If you know the functions
+# you would like to expose, you can do so at register time with the `exposed`
+# attribute. Since we don't we will add a wrapper around the returned AutoProxy

Review Comment:
   ```suggestion
   # attribute. Since we don't, we will add a wrapper around the returned AutoProxy
   ```



##########
sdks/python/apache_beam/utils/multi_process_shared.py:
##########
@@ -126,6 +134,24 @@ class _SingletonRegistrar(multiprocessing.managers.BaseManager):
     callable=_process_level_singleton_manager.release_singleton)
 
 
+# By default, objects registered with BaseManager.register will have only
+# public methods available (excluding __call__). If you know the functions
+# you would like to expose, you can do so at register time with the `exposed`
+# attribute. Since we don't we will add a wrapper around the returned AutoProxy
+# object to handle __call__ function calls and turn them into
+# singletonProxy_call__ calls (which is a wrapper around the underlying
+# object's __call__ function)
+class _AutoProxyWrapper:
+  def __init__(self, proxyObject):

Review Comment:
   provide type annotations if possible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1512096499

   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1503366552

   Run Python_Runners PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1502102992

   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1520511722

   Run Python_Integration PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1503365526

   Run Python PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #26202: [WIP] Allow multi_process_shared objects to be called

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1502040860

   ## [Codecov](https://codecov.io/gh/apache/beam/pull/26202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#26202](https://codecov.io/gh/apache/beam/pull/26202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7563bc3) into [master](https://codecov.io/gh/apache/beam/commit/87db1ae2c04e8589590e6cf8784b5d6d36878241?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87db1ae) will **decrease** coverage by `0.01%`.
   > The diff coverage is `93.75%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #26202      +/-   ##
   ==========================================
   - Coverage   71.17%   71.17%   -0.01%     
   ==========================================
     Files         787      787              
     Lines      103294   103330      +36     
   ==========================================
   + Hits        73523    73546      +23     
   - Misses      28283    28296      +13     
     Partials     1488     1488              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `79.85% <93.75%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/26202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...s/python/apache\_beam/utils/multi\_process\_shared.py](https://codecov.io/gh/apache/beam/pull/26202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvbXVsdGlfcHJvY2Vzc19zaGFyZWQucHk=) | `96.87% <93.75%> (-0.50%)` | :arrow_down: |
   
   ... and [10 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26202/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm merged pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #26202:
URL: https://github.com/apache/beam/pull/26202


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1502193937

   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1503365979

   Run PythonDocker PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #26202: Allow multi_process_shared objects to be called

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26202:
URL: https://github.com/apache/beam/pull/26202#issuecomment-1502102884

   flakes are due to jenkins issues


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org