You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/06 10:56:00 UTC

[jira] [Commented] (AIRFLOW-3310) Google Cloud Spanner deploy / delete operators

    [ https://issues.apache.org/jira/browse/AIRFLOW-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711275#comment-16711275 ] 

ASF GitHub Bot commented on AIRFLOW-3310:
-----------------------------------------

sprzedwojski opened a new pull request #4286: [AIRFLOW-3310] Google Cloud Spanner deploy / delete operators
URL: https://github.com/apache/incubator-airflow/pull/4286
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3310) issues and references them in the PR title.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Added 2 operators for Google Cloud Spanner:
   
   1. `CloudSpannerInstanceDeployOperator`
   Creates a new Cloud Spanner instance or, if an instance with the same `instance_id` exists in the specified project, updates it.
   
   2. `CloudSpannerInstanceDeleteOperator`
   Deletes a Cloud Spanner instance.
   If an instance does not exist, no action will be taken and the operator will succeed.
   
   ### Tests
   
   - [x] My PR adds the following unit tests:
   `test_gcp_spanner_operator.py`
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Google Cloud Spanner deploy / delete operators
> ----------------------------------------------
>
>                 Key: AIRFLOW-3310
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3310
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: gcp
>            Reporter: Szymon Przedwojski
>            Assignee: Szymon Przedwojski
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)