[jira] [Comment Edited] (FINERACT-764) Run Integration Tests using Spring Boot IT support instead of on Tomcat started separately by gradle-tomcat-plugin

["Michael Vorburger.ch (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863591#comment-16863591 ] 

Michael Vorburger.ch edited comment on FINERACT-764 at 6/14/19 1:21 AM:
------------------------------------------------------------------------

> will every file in the fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ need to modified ie basically adding the {{@SpringBootTest?}}

[~muarachmann] yeah, basically. So just re-add MariaDB4j but only as a dependency with scope test, not runtime, we don't want to bloat the final WAR with MariaDB4j, and move the fineract-provider/src/test/java/org/apache/fineract/infrastructure/core/boot/tests/AbstractSpringBootWithMariaDB4jIntegrationTest.java as well as that SpringBootServerLoginTest.java (remove the {{@Ignore("Failing on Cloubees")} please) into {{fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/}} and make each of those tests there extends AbstractSpringBootWithMariaDB4jIntegrationTest - I'm curious if that will work, but I think it should - I don't see why it wouldn't.

Is this something you could make time and raise a PR for? For this I would just start a new PR, off [my latest #525|https://github.com/apache/fineract/pull/525], not [your #550|https://github.com/apache/fineract/pull/550].


was (Author: vorburger):
> will every file in the fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ need to modified ie basically adding the {{@SpringBootTest?}}

[~muarachmann] yeah, basically. So just re-add MariaDB4j but only as a dependency with scope test, not runtime, we don't want to bloat the final WAR with MariaDB4j, and move the fineract-provider/src/test/java/org/apache/fineract/infrastructure/core/boot/tests/AbstractSpringBootWithMariaDB4jIntegrationTest.java as well as that SpringBootServerLoginTest.java (remove the {{@Ignore("Failing on Cloubees")} please) into {{fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/}} and make each of those tests there extends AbstractSpringBootWithMariaDB4jIntegrationTest - I'm curious if that will work, but I think it should - I don't see why it wouldn't.

Is this something you could make time and raise a PR for? For this I would just start a new PR, off [my latest #525](https://github.com/apache/fineract/pull/525), not [your #550](https://github.com/apache/fineract/pull/550).

> Run Integration Tests using Spring Boot IT support instead of on Tomcat started separately by gradle-tomcat-plugin
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-764
>                 URL: https://issues.apache.org/jira/browse/FINERACT-764
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger.ch
>            Priority: Major
>
> https://github.com/apache/fineract/pull/525 for FINERACT-700 struggles to get "./gradlew integrationTest" working under an up-to-date Gradle version, due to the gradle-tomcat-plugin failing to start Tomcat. The problem can also be seen (on that PR, as it stands right now) via {{./gradlew tomcatrunwar}}.
> https://github.com/bmuschko/gradle-tomcat-plugin mentions that its author "I don't have much time to contribute anymore. In practice this means far less activity, responsiveness on issues and new releases from my end."
> What we IMHO really should do instead is to ditch our use of gradle-tomcat-plugin and just use Spring Boot's very nice built-in support for Integration Test, see here:
> * https://docs.spring.io/spring-boot/docs/2.1.5.RELEASE/reference/htmlsingle/#boot-features-testing-spring-applications
> * https://www.baeldung.com/spring-boot-testing (see 7. Integration Testing with @SpringBootTest)
> * https://reflectoring.io/spring-boot-test/
> I wouldn't have time for this, but perhaps someone would like to pick this up?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)