Re: [PR] [ISSUE #10985] Handle exceptional POP revive reads without losing retry [rocketmq]

["ai-yang (via GitHub)" <gi...@apache.org>]

ai-yang commented on PR #10986:
URL: https://github.com/apache/rocketmq/pull/10986#issuecomment-5634118837

   Refreshed onto `develop` at `1a50c6e4e` and pushed signed-off commit `e60e409ba`. The base includes #11086's `OffsetResetIT` stabilization, addressing the test area that failed on the previous Bazel run. The POP production patch is unchanged by the rebase.
   
   Latest JDK 8 verification: `PopReviveServiceTest` passed 13/13; the full 11-module targeted broker reactor succeeded with Checkstyle and SpotBugs enabled for project code. Full CI is running again on the refreshed head.
   
   I also documented the overlap with #11023: both use the same read-stage fallback; this PR includes the regression asserting offset advancement, checkpoint rewrite, and in-flight cleanup. @zjncs, thanks for investigating the same issue; could we coordinate around one implementation and retain that test coverage?
   
   @lizhimins @xdkxlk, could you take a human review of the retry semantics and help select the consolidation path when convenient?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org