You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/01 08:29:55 UTC

[PR] Refactor MCP Encrypt workflow feature state [shardingsphere]

terrymanu opened a new pull request, #39304:
URL: https://github.com/apache/shardingsphere/pull/39304

   Reuse RuleWorkflowFeatureData in Encrypt workflow planning and validation. Remove the duplicate EncryptWorkflowState model and its redundant test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor MCP Encrypt workflow feature state [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39304:
URL: https://github.com/apache/shardingsphere/pull/39304#issuecomment-5150644592

   ### Result
   
   **Review Result: Mergeable**
   
   The refactor preserves behavior and removes a duplicate state model without introducing correctness or compatibility issues.
   
   ### Evidence
   
   - [PR #39304](https://github.com/apache/shardingsphere/pull/39304) changes five files and replaces `EncryptWorkflowState` with the equivalent `RuleWorkflowFeatureData`.
   - No remaining repository references to `EncryptWorkflowState` were found.
   - Focused encrypt tests passed: 34 tests, 0 failures; Maven build succeeded.
   
   ### Coverage
   
   Reviewed head `88245954a35`, base `92c4c8ed618`, and all five changed files.
   
   Behavior clusters covered:
   
   - Encrypt planning state creation and reuse.
   - Encrypt validation expected-rule lookup.
   - Handler fixture cleanup and deleted redundant model test.
   
   Completed root-cause/behavior, blast-radius/contracts, and tests/runtime/operations reviews. No unresolved evidence gaps. This was a code-correctness review; GitHub Actions and CI status were not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor MCP Encrypt workflow feature state [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39304:
URL: https://github.com/apache/shardingsphere/pull/39304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org