You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/02/19 19:16:20 UTC
[GitHub] [ignite] timoninmaxim opened a new pull request #8816: Wait for Grid process instead of Kill process
timoninmaxim opened a new pull request #8816:
URL: https://github.com/apache/ignite/pull/8816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #8816: IGNITE-14219 Wait for Grid process instead of Kill process
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #8816:
URL: https://github.com/apache/ignite/pull/8816#discussion_r581706827
##########
File path: modules/compatibility/src/test/java/org/apache/ignite/compatibility/clients/AbstractClientCompatibilityTest.java
##########
@@ -157,23 +157,13 @@ public void testCurrentClientToOldServer() throws Exception {
initNode(ignite);
}
- else {
- Ignite ignite = startGrid(1, verFormatted, this::processRemoteConfiguration, this::initNode);
-
- proxy = IgniteProcessProxy.ignite(ignite.name());
- }
+ else
+ startGrid(1, verFormatted, this::processRemoteConfiguration, this::initNode);
Review comment:
`proxy` variable is redundant now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #8816: IGNITE-14219 Wait for Grid process instead of Kill process
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #8816:
URL: https://github.com/apache/ignite/pull/8816#discussion_r581718511
##########
File path: modules/compatibility/src/test/java/org/apache/ignite/compatibility/clients/AbstractClientCompatibilityTest.java
##########
@@ -157,23 +157,13 @@ public void testCurrentClientToOldServer() throws Exception {
initNode(ignite);
}
- else {
- Ignite ignite = startGrid(1, verFormatted, this::processRemoteConfiguration, this::initNode);
-
- proxy = IgniteProcessProxy.ignite(ignite.name());
- }
+ else
+ startGrid(1, verFormatted, this::processRemoteConfiguration, this::initNode);
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov merged pull request #8816: IGNITE-14219 Wait for Grid process instead of Kill process
Posted by GitBox <gi...@apache.org>.
anton-vinogradov merged pull request #8816:
URL: https://github.com/apache/ignite/pull/8816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org