You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@classsoftware.com> on 2013/11/19 03:41:51 UTC
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is that th
Hi,
I checked all the before and after bitmaps and found one issue.
In the ActionBar_TitleDisplay_TextDecoration test, the underline on the text Default Style is incorrect on the after bitmap as it turns black where it crosses the descender of the "y".
Thanks,
Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
And also in SDK 4.10 GA.
So let's recap:
- running with the current SDK a standalone mobile air app that displays an action bar with embedded font and underline => no artifact
- running current mustella test mobile/Action with current SDK => artifact is there
- running current mustella test mobile/Action with SKD 4.11 and 4.10 => artifact is there
So it must be a change in the mustella test that caused this issue.
Last test to run, is to revert the mustella test on Mobile ActionBar Style TextDecoration to previous version, and see what happens.
(Note: Git log shows there have been some changes on these files in January 2013...)
I stop now, it's getting very late here.
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
Envoyé : mercredi 20 novembre 2013 02:48
À : dev@flex.apache.org
Objet : RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Some interesting findings:
This is what I did:
In mustella, local.properties, set
sdk.dir to point to latest SDK 4.11 GA
apollo_location=${sdk.dir}
then run again the same test.
The log says:
[echo] sdk.dir: C:/Program Files (x86)/Apache Flex/Apache_Flex_SDK_411_GA
...
[echo] apollo_location is C:/Program Files (x86)/Apache Flex/Apache_Flex_SDK_411_GA
Guess what ?
The "black" artifact between the underline and the "y" was already there...
So how it went through the release , I have no idea...
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
Envoyé : mercredi 20 novembre 2013 02:23 À : dev@flex.apache.org Objet : RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
>Another possibility is that the tests in the file have side-effects. Are you running a single test or all tests in a folder? Sometimes the other tests in a folder affect the >bitmap of a single test.
I have run all the tests in mobile/ActionBar/styles, same result
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com] Envoyé : mercredi 20 novembre 2013 01:35 À : dev@flex.apache.org Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Another possibility is that the tests in the file have side-effects. Are you running a single test or all tests in a folder? Sometimes the other tests in a folder affect the bitmap of a single test.
-Alex
On 11/19/13 3:15 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> Same result...on "y" and underline.
>
>Or another recent check in? You can revert the check in for that image
>as the change is unrelated to your fix.
>
>Thanks,
>Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
Some interesting findings:
This is what I did:
In mustella, local.properties, set
sdk.dir to point to latest SDK 4.11 GA
apollo_location=${sdk.dir}
then run again the same test.
The log says:
[echo] sdk.dir: C:/Program Files (x86)/Apache Flex/Apache_Flex_SDK_411_GA
...
[echo] apollo_location is C:/Program Files (x86)/Apache Flex/Apache_Flex_SDK_411_GA
Guess what ?
The "black" artifact between the underline and the "y" was already there...
So how it went through the release , I have no idea...
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
Envoyé : mercredi 20 novembre 2013 02:23
À : dev@flex.apache.org
Objet : RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
>Another possibility is that the tests in the file have side-effects. Are you running a single test or all tests in a folder? Sometimes the other tests in a folder affect the >bitmap of a single test.
I have run all the tests in mobile/ActionBar/styles, same result
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com] Envoyé : mercredi 20 novembre 2013 01:35 À : dev@flex.apache.org Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Another possibility is that the tests in the file have side-effects. Are you running a single test or all tests in a folder? Sometimes the other tests in a folder affect the bitmap of a single test.
-Alex
On 11/19/13 3:15 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> Same result...on "y" and underline.
>
>Or another recent check in? You can revert the check in for that image
>as the change is unrelated to your fix.
>
>Thanks,
>Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
>Another possibility is that the tests in the file have side-effects. Are you running a single test or all tests in a folder? Sometimes the other tests in a folder affect the >bitmap of a single test.
I have run all the tests in mobile/ActionBar/styles, same result
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com]
Envoyé : mercredi 20 novembre 2013 01:35
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Another possibility is that the tests in the file have side-effects. Are you running a single test or all tests in a folder? Sometimes the other tests in a folder affect the bitmap of a single test.
-Alex
On 11/19/13 3:15 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> Same result...on "y" and underline.
>
>Or another recent check in? You can revert the check in for that image
>as the change is unrelated to your fix.
>
>Thanks,
>Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
>If the bitmap compares exactly the display list is not compared.
Thanks
-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com]
Envoyé : mercredi 20 novembre 2013 01:43
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
On 11/19/13 4:24 PM, "Maurice Amsellem" <ma...@systar.com>
wrote:
>I am not sure of that last point.
>When a baseline provides both the bitmap and the xml DL, and the bitmap
>is the same, but the xml DL differs, Will the test fail, and generate
>.bad for both ?
If the bitmap compares exactly the display list is not compared.
-Alex
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Alex Harui <ah...@adobe.com>.
On 11/19/13 4:24 PM, "Maurice Amsellem" <ma...@systar.com>
wrote:
>I am not sure of that last point.
>When a baseline provides both the bitmap and the xml DL, and the bitmap
>is the same, but the xml DL differs,
>Will the test fail, and generate .bad for both ?
If the bitmap compares exactly the display list is not compared.
-Alex
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
Sorry, of course png is not the same.
There is that black line across the "y".
I am using SvnDiff, which is also rather good (you can overlay, highlight diffs, etc...).
> If your code change didn't cause that bitmap to change why was a new baseline image checked in?
As I said, because of the different XML DL dump, that contained references to ScrollableStageText (new class), so I checked in both.
I am not sure of that last point.
When a baseline provides both the bitmap and the xml DL, and the bitmap is the same, but the xml DL differs,
Will the test fail, and generate .bad for both ?
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : mercredi 20 novembre 2013 01:16
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi,
> The png is the same
The png is not the same look at it before and after in that checkin. Before the underline is entirely white, after it is black where it crosses the "y".
Github has some nice way of checking for bitmap differences.
https://github.com/apache/flex-sdk/commit/9d6c2d34ed64be364ad30acfd0f2fe4f8ab2a12c?diff-0=3-0&diff-1=3-0&diff-2=3-0&diff-3=3-0&diff-4=3-0&diff-5=3-0&diff-6=3-0&diff-7=3-0&diff-8=3-0&diff-9=3-0&diff-10=3-0&diff-11=3-0
(look at very bottom image)
But I noticed the difference in Source Tree by looking and 'Preview before' and 'Preview after' checkins of that image.
If your code change didn't cause that bitmap to change why was a new baseline image checked in?
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> The png is the same
The png is not the same look at it before and after in that checkin. Before the underline is entirely white, after it is black where it crosses the "y".
Github has some nice way of checking for bitmap differences.
https://github.com/apache/flex-sdk/commit/9d6c2d34ed64be364ad30acfd0f2fe4f8ab2a12c?diff-0=3-0&diff-1=3-0&diff-2=3-0&diff-3=3-0&diff-4=3-0&diff-5=3-0&diff-6=3-0&diff-7=3-0&diff-8=3-0&diff-9=3-0&diff-10=3-0&diff-11=3-0
(look at very bottom image)
But I noticed the difference in Source Tree by looking and 'Preview before' and 'Preview after' checkins of that image.
If your code change didn't cause that bitmap to change why was a new baseline image checked in?
Thanks,
Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
I understand.
The png is the same, but the DL.xml is different, as I explained in earlier email, it contains references to ScrollableStageText (my changes) but that are not active (width=0 height=0).
That's why I checked in both, so that they are consistent.
So I will revert both files, until we find the issue...
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : mercredi 20 novembre 2013 00:45
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi,
>> Or another recent check in? You can revert the check in for that image as the change is unrelated to your fix.
>
> Sorry I don't understand, what check in should I revert?
Only the image that has the black line though the "y", if your code didn't cause that image to change then you shouldn't of checked it in. The changes to the other image baselines looked fine to me.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
>> Or another recent check in? You can revert the check in for that image as the change is unrelated to your fix.
>
> Sorry I don't understand, what check in should I revert?
Only the image that has the black line though the "y", if your code didn't cause that image to change then you shouldn't of checked it in. The changes to the other image baselines looked fine to me.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative
FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be
included in scrollable forms - updated mustella baseline bitmaps following
failures. Typical difference is tha...
Posted by OmPrakash Muppirala <bi...@gmail.com>.
You need these files:
<!-- FontSWF -->
<file name="afe" path="
http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/lib/"
file="afe.jar"/>
<file name="aglj40" path="
http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/lib/"
file="aglj40.jar"/>
<file name="flex-fontkit" path="
http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/lib/"
file="flex-fontkit.jar"/>
<file name="rideau" path="
http://opensource.adobe.com/svn/opensource/flex/sdk/branches/4.y/lib/"
file="rideau.jar"/>
They all go in into the {sdk}\lib\external\optional directory.
On Tue, Nov 19, 2013 at 3:41 PM, Maurice Amsellem <
maurice.amsellem@systar.com> wrote:
> >Or another recent check in? You can revert the check in for that image
> as the change is unrelated to your fix.
>
> Sorry I don't understand, what check in should I revert?
>
> BTW, I would like to run the same test on SDK 4.11, so I changed sdk.dir
> in local.properties.
> But it complains that the SDK does not have support for embedded fonts (I
> forgot to install them when downloading the SDK).
>
> Do you know how I can install embedded font support manually ? while file
> needs to be downloaded?
>
> Thanks
>
> Maurice
>
>
> -----Message d'origine-----
> De : Justin Mclean [mailto:justin@classsoftware.com]
> Envoyé : mercredi 20 novembre 2013 00:16
> À : dev@flex.apache.org
> Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
> Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
> cannot be included in scrollable forms - updated mustella baseline bitmaps
> following failures. Typical difference is tha...
>
> Hi,
>
> > Same result...on "y" and underline.
>
> Or another recent check in? You can revert the check in for that image as
> the change is unrelated to your fix.
>
> Thanks,
> Justin
>
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
>Or another recent check in? You can revert the check in for that image as the change is unrelated to your fix.
Sorry I don't understand, what check in should I revert?
BTW, I would like to run the same test on SDK 4.11, so I changed sdk.dir in local.properties.
But it complains that the SDK does not have support for embedded fonts (I forgot to install them when downloading the SDK).
Do you know how I can install embedded font support manually ? while file needs to be downloaded?
Thanks
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : mercredi 20 novembre 2013 00:16
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi,
> Same result...on "y" and underline.
Or another recent check in? You can revert the check in for that image as the change is unrelated to your fix.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Alex Harui <ah...@adobe.com>.
Another possibility is that the tests in the file have side-effects. Are
you running a single test or all tests in a folder? Sometimes the other
tests in a folder affect the bitmap of a single test.
-Alex
On 11/19/13 3:15 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> Same result...on "y" and underline.
>
>Or another recent check in? You can revert the check in for that image as
>the change is unrelated to your fix.
>
>Thanks,
>Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Same result...on "y" and underline.
Or another recent check in? You can revert the check in for that image as the change is unrelated to your fix.
Thanks,
Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
Rebuilt the full SDK , and re-run the tests.
Same result...on "y" and underline.
So maybe AIR 3.9/FP 11.9
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
Envoyé : mardi 19 novembre 2013 23:36
À : dev@flex.apache.org
Objet : RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
>Possibly silly question but you did recompile the entire framework before running the the tests? That's caught me out once or twice.
Of course, how stupid I am.
I "pulled" all the changes from the remote develop, but didn't recompile the framework to make them effective.
I am doing that right now...
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : mardi 19 novembre 2013 23:30 À : dev@flex.apache.org Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi,
> How is it possible to know when the test above succeeded for the last time ?
Possibly silly question but you did recompile the entire framework before running the the tests? That's caught me out once or twice.
> Maybe it was before we moved to AIR3.9/FP 11.9...
That's also a possibility.
Thanks,
Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
>Possibly silly question but you did recompile the entire framework before running the the tests? That's caught me out once or twice.
Of course, how stupid I am.
I "pulled" all the changes from the remote develop, but didn't recompile the framework to make them effective.
I am doing that right now...
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : mardi 19 novembre 2013 23:30
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi,
> How is it possible to know when the test above succeeded for the last time ?
Possibly silly question but you did recompile the entire framework before running the the tests? That's caught me out once or twice.
> Maybe it was before we moved to AIR3.9/FP 11.9...
That's also a possibility.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> How is it possible to know when the test above succeeded for the last time ?
Possibly silly question but you did recompile the entire framework before running the the tests? That's caught me out once or twice.
> Maybe it was before we moved to AIR3.9/FP 11.9...
That's also a possibility.
Thanks,
Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
Justin,
I removed all my changes on my local git copy (applied revert patch), including reverting the baseline bitmap.
Then generated the faulty test:
$ ./mini_run.sh -mobile -caseName=ActionBar_TitleDisplay_TextDecoration tests/mobile/components/ActionBar/styles/ActionBar_Styles.mxml
As excepted, the tests failed, and it generated png and DL xml.
I checked that DL.xml does not contain any reference to Scroll***
I have attached them to the JIRA ticket, so it's easier to share:
https://issues.apache.org/jira/browse/FLEX-33166
ActionBar_TitleDisplay_TextDecoration@android_240ppi.png 2 kB image/png Today 22:19 Maurice Amsellem
ActionBar_TitleDisplay_TextDecoration@android_240ppi.png.bad.png 2 kB image/png Today 22:19 Maurice Amsellem
ActionBar_TitleDisplay_TextDecoration@android_240ppi.png.bad.png.xml 40 kB text/xml Today 22:19 Maurice Amsellem
ActionBar_TitleDisplay_TextDecoration@android_240ppi.png.xml 39 kB text/xml Today 22:19
It's interesting that the DL are rather different...
You can have a look if you wish.
How is it possible to know when the test above succeeded for the last time ?
Maybe it was before we moved to AIR3.9/FP 11.9...
Just saying ;-)
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : mardi 19 novembre 2013 23:00
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi,
> Before of removing all the changes I made (that's a lot of work, and I am really running out of time),
I wasn't suggesting that just the single bitmap that was checked in in error, so we know there's still an issue. Then we try and hunt for it's cause.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Before of removing all the changes I made (that's a lot of work, and I am really running out of time),
I wasn't suggesting that just the single bitmap that was checked in in error, so we know there's still an issue. Then we try and hunt for it's cause.
Thanks,
Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
>Then you need to revert the change to that single bitmap and we need to find (and fix or revert) what checkin did cause the issue.
Before of removing all the changes I made (that's a lot of work, and I am really running out of time), I propose to set back defaults.css to use the original StageTextInputSkin / StageTextAreaSkin, and of course reverting the bitmap.
I can try already the above proposition on my PC, to see what happens.
WDYT?
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : mardi 19 novembre 2013 22:31
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi,
> To be absolutely sure it was not related to TextInput.
Then you need to revert the change to that single bitmap and we need to find (and fix or revert) what checkin did cause the issue.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> To be absolutely sure it was not related to TextInput.
Then you need to revert the change to that single bitmap and we need to find (and fix or revert) what checkin did cause the issue.
Thanks,
Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
To be absolutely sure it was not related to TextInput, this is what I did:
In /components/ActionBar/swfs/ActionBar.mxml
I removed all the content, except:
<comps:ActionBarBasic id="actionBar" />
Then I did a minirun on that special test case:
./mini_run.sh -mobile -caseName=ActionBar_TitleDisplay_TextDecoration tests/mobile/components/ActionBar/styles/ActionBar_Styles.mxml
The "black" in the crossing still appears.
I also tried generating baselines for that test, and the new XML DL has only one StyleableTextField, and the black artifact is still there.
So it's something new in StyleableTextField, not ScrollableStageText.
WDYT ?
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com]
Envoyé : mardi 19 novembre 2013 15:11
À : dev@flex.apache.org
Objet : RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi Justin,
I think you are talking about: baselines/ ActionBar_TitleDisplay_TextDecoration@android_240ppi.png, which is the only one that turns black when crossing the descender "y".
I found it weird at first sight, because StyleableStageText / ScrollableStageText does not even have a textDecoration style, so how can it be wrong ?
So to understand, I had to parse the DL xml file:
Search for the text "Default Style", you will that only ActionBarSkin.as$58.TitleDisplayComponent has it one line#26 and it's a StyleableTextField.
The ScrollableStageText is completely at the end, and their parent container has width=0 & height=0.
In fact, all action bar except the one above have width=0 & height=0.
So it shouldn't have any influence on the display, in theory.
But then, why is there a difference BEFORE/AFTER ? is it a Flash Player artifact ?
Any clue ?
Thanks
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com] Envoyé : mardi 19 novembre 2013 03:42 À : dev@flex.apache.org Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi,
I checked all the before and after bitmaps and found one issue.
In the ActionBar_TitleDisplay_TextDecoration test, the underline on the text Default Style is incorrect on the after bitmap as it turns black where it crosses the descender of the "y".
Thanks,
Justin
RE: git commit: [flex-sdk] [refs/heads/develop] - UPDATED -
Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput
cannot be included in scrollable forms - updated mustella baseline bitmaps
following failures. Typical difference is tha...
Posted by Maurice Amsellem <ma...@systar.com>.
Hi Justin,
I think you are talking about: baselines/ ActionBar_TitleDisplay_TextDecoration@android_240ppi.png, which is the only one that turns black when crossing the descender "y".
I found it weird at first sight, because StyleableStageText / ScrollableStageText does not even have a textDecoration style, so how can it be wrong ?
So to understand, I had to parse the DL xml file:
Search for the text "Default Style", you will that only ActionBarSkin.as$58.TitleDisplayComponent has it one line#26
and it's a StyleableTextField.
The ScrollableStageText is completely at the end, and their parent container has width=0 & height=0.
In fact, all action bar except the one above have width=0 & height=0.
So it shouldn't have any influence on the display, in theory.
But then, why is there a difference BEFORE/AFTER ? is it a Flash Player artifact ?
Any clue ?
Thanks
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:justin@classsoftware.com]
Envoyé : mardi 19 novembre 2013 03:42
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - UPDATED - Tentative FIX of FLEX-33166 Mobile TextInput with native StageTextInput cannot be included in scrollable forms - updated mustella baseline bitmaps following failures. Typical difference is tha...
Hi,
I checked all the before and after bitmaps and found one issue.
In the ActionBar_TitleDisplay_TextDecoration test, the underline on the text Default Style is incorrect on the after bitmap as it turns black where it crosses the descender of the "y".
Thanks,
Justin