You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/12/30 14:00:35 UTC

[commons-codec] branch release updated: [CODEC-276] Reliance on default encoding in MurmurHash2 and MurmurHash3.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch release
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/release by this push:
     new f3fe3af  [CODEC-276] Reliance on default encoding in MurmurHash2 and MurmurHash3.
f3fe3af is described below

commit f3fe3afb3f301f236328801bfcd272de57dbccd5
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Dec 30 09:00:32 2019 -0500

    [CODEC-276] Reliance on default encoding in MurmurHash2 and MurmurHash3.
    
    Update Javadoc with fix from Alex Herbert.
---
 src/main/java/org/apache/commons/codec/digest/MurmurHash2.java | 10 ++++++++--
 src/main/java/org/apache/commons/codec/digest/MurmurHash3.java | 10 ++++++++--
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/digest/MurmurHash2.java b/src/main/java/org/apache/commons/codec/digest/MurmurHash2.java
index 4dfeca9..12c1c2d 100644
--- a/src/main/java/org/apache/commons/codec/digest/MurmurHash2.java
+++ b/src/main/java/org/apache/commons/codec/digest/MurmurHash2.java
@@ -137,7 +137,10 @@ public final class MurmurHash2 {
 
     /**
      * Generates a 32-bit hash from a string with a default seed.
-     * The string is converted to bytes using the default encoding.
+     * <p>
+     * Before 1.14 the string was converted using default encoding. 
+     * Since 1.14 the string is converted to bytes using UTF-8 encoding.
+     * </p>
      * This is a helper method that will produce the same result as:
      *
      * <pre>
@@ -248,7 +251,10 @@ public final class MurmurHash2 {
 
     /**
      * Generates a 64-bit hash from a string with a default seed.
-     * The string is converted to bytes using the default encoding.
+     * <p>
+     * Before 1.14 the string was converted using default encoding. 
+     * Since 1.14 the string is converted to bytes using UTF-8 encoding.
+     * </p>
      * This is a helper method that will produce the same result as:
      *
      * <pre>
diff --git a/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java b/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java
index 4509a8f..059f9af 100644
--- a/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java
+++ b/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java
@@ -237,7 +237,10 @@ public final class MurmurHash3 {
 
     /**
      * Generates 32-bit hash from a string with a default seed.
-     * The string is converted to bytes using the default encoding.
+     * <p>
+     * Before 1.14 the string was converted using default encoding. 
+     * Since 1.14 the string is converted to bytes using UTF-8 encoding.
+     * </p>
      * This is a helper method that will produce the same result as:
      *
      * <pre>
@@ -755,7 +758,10 @@ public final class MurmurHash3 {
 
     /**
      * Generates 128-bit hash from a string with a default seed.
-     * The string is converted to bytes using the default encoding.
+     * <p>
+     * Before 1.14 the string was converted using default encoding. 
+     * Since 1.14 the string is converted to bytes using UTF-8 encoding.
+     * </p>
      * This is a helper method that will produce the same result as:
      *
      * <pre>