You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/03/31 20:40:26 UTC

[GitHub] [drill] paul-rogers opened a new pull request #2046: DRILL-7680: Place UDFs before plugins in contrib

paul-rogers opened a new pull request #2046: DRILL-7680: Place UDFs before plugins in contrib
URL: https://github.com/apache/drill/pull/2046
 
 
   # [DRILL-7680](https://issues.apache.org/jira/browse/DRILL-7680): Place UDFs before plugins in contrib
   
   ## Description
   
   Several contrib plugins depend on UDFs for testing. However, the UDFs occur after the plugins in build order. This PR reverses the dependencies so that UDFs are built before the plguins that want to use them.
   
   ## Documentation
   
   N/A
   
   ## Testing
   
   Did a full build, with unit tests, to ensure everything still works.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] arina-ielchiieva commented on issue #2046: DRILL-7680: Place UDFs before plugins in contrib

Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #2046: DRILL-7680: Place UDFs before plugins in contrib
URL: https://github.com/apache/drill/pull/2046#issuecomment-607105732
 
 
   @paul-rogers 
   
   > Do know of any case where a UDF depends on a storage plugin? Not sure how what would be possible, given how UDFs work, but would be good to double-check.
   
   I don't. I never faced problems you are describing here, that's why I was asking the questions :)
   
   Anyway, thanks for the explanation, +1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] paul-rogers commented on issue #2046: DRILL-7680: Place UDFs before plugins in contrib

Posted by GitBox <gi...@apache.org>.
paul-rogers commented on issue #2046: DRILL-7680: Place UDFs before plugins in contrib
URL: https://github.com/apache/drill/pull/2046#issuecomment-606899953
 
 
   @arina-ielchiieva, good point. Updated the description to clearly state the dependency. Turns out Charles ran into this issue with the ESRI plugin, and I ran into it with a private plugin.
   
   Do know of any case where a UDF depends on a storage plugin? Not sure how what would be possible, given how UDFs work, but would be good to double-check.
   
   By the way, once I get a chance to return to the SPI interface, a single service provider can provide both a plugin and associated UDFs, so that will help reduce the dependency issues. (That is how Presto does their extensions.) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] arina-ielchiieva commented on issue #2046: DRILL-7680: Place UDFs before plugins in contrib

Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #2046: DRILL-7680: Place UDFs before plugins in contrib
URL: https://github.com/apache/drill/pull/2046#issuecomment-606889189
 
 
   @paul-rogers I don't mind this change, just wanted to clarify what exactly happens and when you see problems with this order, description is quite general so I am not quite sure when failures occur.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] arina-ielchiieva merged pull request #2046: DRILL-7680: Place UDFs before plugins in contrib

Posted by GitBox <gi...@apache.org>.
arina-ielchiieva merged pull request #2046: DRILL-7680: Place UDFs before plugins in contrib
URL: https://github.com/apache/drill/pull/2046
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services