You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/01/27 15:39:36 UTC
[GitHub] flink pull request #3226: [FLINK-5667] [state] Synchronize asynchronous chec...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3226
[FLINK-5667] [state] Synchronize asynchronous checkpointing and close operation
This PR synchronizes asynchronous checkpointing and close operations of a StreamTask.
The synchronization prevents that an acknowledged checkpoint gets discarded and that
a discarded checkpoint gets acknowledged. It achieves this by introducing an atomic
state variable which guards against late close and acknowledge operations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink asyncCheckpointingFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3226
----
commit 16ce24f6d062ade2f3bb3d41059ced71b7040c52
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-01-27T15:26:22Z
[FLINK-5667] [state] Synchronize asynchronous checkpointing and close operation
This PR synchronizes asynchronous checkpointing and close operations of a StreamTask.
The synchronization prevents that an acknowledged checkpoint gets discarded and that
a discarded checkpoint gets acknowledged. It achieves this by introducing an atomic
state variable which guards against late close and acknowledge operations.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3226: [FLINK-5667] [state] Synchronize asynchronous checkpointi...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3226
Thanks for the review @uce. Will address @StefanRRichter comment from #3227 and then merge the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3226: [FLINK-5667] [state] Synchronize asynchronous checkpointi...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3226
Thanks! +1 to merge this and #3227. Verified that tests catch both orderings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3226: [FLINK-5667] [state] Synchronize asynchronous chec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3226
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3226: [FLINK-5667] [state] Synchronize asynchronous checkpointi...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3226
Thanks @tillrohrmann ! Very good to have this fixed :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---