[GitHub] [netbeans] lbownik commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.

[GitBox <gi...@apache.org>]

lbownik commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1037968907


##########
java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java:
##########
@@ -225,6 +236,49 @@ public void run() {
         int executionresult = -10;
         final InputOutput ioput = getInputOutput();
 
+        MavenProxySupport mps = clonedConfig.getProject().getLookup().lookup(MavenProxySupport.class);
+        if (mps != null) {
+            MavenProxySupport.ProxyResult res;

Review Comment:
   how about moving it to line 244 where it can be instanlty initialized?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists