You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Josh Holtzman (JIRA)" <ji...@apache.org> on 2010/03/19 07:59:27 UTC

[jira] Created: (DOSGI-67) Enable filters on DOSGi endpoints

Enable filters on DOSGi endpoints
---------------------------------

                 Key: DOSGI-67
                 URL: https://issues.apache.org/jira/browse/DOSGI-67
             Project: CXF Distributed OSGi
          Issue Type: Improvement
    Affects Versions: 1.1
            Reporter: Josh Holtzman
             Fix For: 1.2
         Attachments: dosgi_filterchain.diff

Allow any bundle to register a filter that is applied globally to DOSGi endpoints.  The attached patch adds this capability to JAX-RS endpoints, and could easily be modified to apply to all DOSGi endpoints.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DOSGI-67) Enable filters on DOSGi endpoints

Posted by "Josh Holtzman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DOSGI-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Holtzman updated DOSGI-67:
-------------------------------

    Attachment: dosgi_filterchain.diff

> Enable filters on DOSGi endpoints
> ---------------------------------
>
>                 Key: DOSGI-67
>                 URL: https://issues.apache.org/jira/browse/DOSGI-67
>             Project: CXF Distributed OSGi
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Josh Holtzman
>             Fix For: 1.2
>
>         Attachments: dosgi_filterchain.diff
>
>
> Allow any bundle to register a filter that is applied globally to DOSGi endpoints.  The attached patch adds this capability to JAX-RS endpoints, and could easily be modified to apply to all DOSGi endpoints.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DOSGI-67) Enable filters on DOSGi endpoints

Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DOSGI-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergey Beryozkin reassigned DOSGI-67:
-------------------------------------

    Assignee: Sergey Beryozkin

> Enable filters on DOSGi endpoints
> ---------------------------------
>
>                 Key: DOSGI-67
>                 URL: https://issues.apache.org/jira/browse/DOSGI-67
>             Project: CXF Distributed OSGi
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Josh Holtzman
>            Assignee: Sergey Beryozkin
>             Fix For: 1.2
>
>         Attachments: dosgi_filterchain.diff, dosgi_filterchain.diff
>
>
> Allow any bundle to register a filter that is applied globally to DOSGi endpoints.  The attached patch adds this capability to JAX-RS endpoints, and could easily be modified to apply to all DOSGi endpoints.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DOSGI-67) Enable filters on DOSGi endpoints

Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DOSGI-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849669#action_12849669 ] 

Sergey Beryozkin commented on DOSGI-67:
---------------------------------------

Hi Josh

thanks a million. I'm in the middle of something else, but I will apply your patch asap. 
I might also introduce a property which will disable quering for the filters altogether.



cheers, Sergey  

> Enable filters on DOSGi endpoints
> ---------------------------------
>
>                 Key: DOSGI-67
>                 URL: https://issues.apache.org/jira/browse/DOSGI-67
>             Project: CXF Distributed OSGi
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Josh Holtzman
>            Assignee: Sergey Beryozkin
>             Fix For: 1.2
>
>         Attachments: dosgi_filterchain.diff, dosgi_filterchain.diff
>
>
> Allow any bundle to register a filter that is applied globally to DOSGi endpoints.  The attached patch adds this capability to JAX-RS endpoints, and could easily be modified to apply to all DOSGi endpoints.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DOSGI-67) Enable filters on DOSGi endpoints

Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DOSGI-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergey Beryozkin resolved DOSGI-67.
-----------------------------------

    Resolution: Fixed

Hi Josh, I applied your patch, sorry for a delay. I only changed the name of the demo to 'security_filter', perhaps it can be enhanced later on to demo how spring_security, etc can be used

cheers, Sergey

> Enable filters on DOSGi endpoints
> ---------------------------------
>
>                 Key: DOSGI-67
>                 URL: https://issues.apache.org/jira/browse/DOSGI-67
>             Project: CXF Distributed OSGi
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Josh Holtzman
>            Assignee: Sergey Beryozkin
>             Fix For: 1.2
>
>         Attachments: dosgi_filterchain.diff, dosgi_filterchain.diff, dosgi_filterchain.diff
>
>
> Allow any bundle to register a filter that is applied globally to DOSGi endpoints.  The attached patch adds this capability to JAX-RS endpoints, and could easily be modified to apply to all DOSGi endpoints.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DOSGI-67) Enable filters on DOSGi endpoints

Posted by "David Bosschaert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DOSGI-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849700#action_12849700 ] 

David Bosschaert commented on DOSGI-67:
---------------------------------------

Nice work Josh, I see you've included a sample as well.

I have one small comment. I see that you introduced a dependency on spring-test. If I understand it correctly this is purely for the MockHttpServletRequest and MockHttpServletResponse.
It seems like these can also be implemented using EasyMock which is the mock framework that is generally used in the tests...
Reason I'm a little cautious about spring-test is because the DOSGi system tests used to be based on it but it caused interference with the spring bundles used by CXF-DOSGi itself, so I've recently changed the system tests deps away from spring test to use Pax Exam. The interference might not be a problem in your use of it but it would still be nice if we can reuse EasyMock as it's already there...

Oh and finally, it would be nice if you could put a little bit of documentation around the demo at the DOSGi docs wiki too.

> Enable filters on DOSGi endpoints
> ---------------------------------
>
>                 Key: DOSGI-67
>                 URL: https://issues.apache.org/jira/browse/DOSGI-67
>             Project: CXF Distributed OSGi
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Josh Holtzman
>            Assignee: Sergey Beryozkin
>             Fix For: 1.2
>
>         Attachments: dosgi_filterchain.diff, dosgi_filterchain.diff
>
>
> Allow any bundle to register a filter that is applied globally to DOSGi endpoints.  The attached patch adds this capability to JAX-RS endpoints, and could easily be modified to apply to all DOSGi endpoints.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DOSGI-67) Enable filters on DOSGi endpoints

Posted by "Josh Holtzman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DOSGI-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Holtzman updated DOSGI-67:
-------------------------------

    Attachment: dosgi_filterchain.diff

Interesting... I didn't realize that cxf had a history of issues with spring-test.  I've removed the spring-test dependency and attached a new version of the patch.

I'm working with my employer to get a CLA to Apache.  Once that's complete, I'll update the wiki with a walkthrough of the security sample application.

> Enable filters on DOSGi endpoints
> ---------------------------------
>
>                 Key: DOSGI-67
>                 URL: https://issues.apache.org/jira/browse/DOSGI-67
>             Project: CXF Distributed OSGi
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Josh Holtzman
>            Assignee: Sergey Beryozkin
>             Fix For: 1.2
>
>         Attachments: dosgi_filterchain.diff, dosgi_filterchain.diff, dosgi_filterchain.diff
>
>
> Allow any bundle to register a filter that is applied globally to DOSGi endpoints.  The attached patch adds this capability to JAX-RS endpoints, and could easily be modified to apply to all DOSGi endpoints.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DOSGI-67) Enable filters on DOSGi endpoints

Posted by "Josh Holtzman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DOSGI-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Holtzman updated DOSGI-67:
-------------------------------

    Attachment: dosgi_filterchain.diff

Attaching an updated version of the patch.  This version includes support for soap and rest endpoints, and includes unit tests and samples.

> Enable filters on DOSGi endpoints
> ---------------------------------
>
>                 Key: DOSGI-67
>                 URL: https://issues.apache.org/jira/browse/DOSGI-67
>             Project: CXF Distributed OSGi
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Josh Holtzman
>             Fix For: 1.2
>
>         Attachments: dosgi_filterchain.diff, dosgi_filterchain.diff
>
>
> Allow any bundle to register a filter that is applied globally to DOSGi endpoints.  The attached patch adds this capability to JAX-RS endpoints, and could easily be modified to apply to all DOSGi endpoints.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.