You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2017/03/17 12:40:15 UTC
kafka git commit: MINOR: Increase Throttle lower bound assertion in
throttling_test
Repository: kafka
Updated Branches:
refs/heads/trunk c5adf17ae -> 6b11fb7af
MINOR: Increase Throttle lower bound assertion in throttling_test
Improves the reliability of this test by decreasing the lower bound (this is to be expected as throttling takes the first fetch to stabilise and will "over-fetch" for this first request)
Author: Ben Stopford <be...@gmail.com>
Reviewers: Apurva Mehta <ap...@confluent.io>, Ismael Juma <is...@juma.me.uk>
Closes #2698 from benstopford/throttling-test-fix
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/6b11fb7a
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/6b11fb7a
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/6b11fb7a
Branch: refs/heads/trunk
Commit: 6b11fb7af81390789ba449c0cd5daa81c8ee9cb5
Parents: c5adf17
Author: Ben Stopford <be...@gmail.com>
Authored: Fri Mar 17 12:39:53 2017 +0000
Committer: Ismael Juma <is...@juma.me.uk>
Committed: Fri Mar 17 12:39:53 2017 +0000
----------------------------------------------------------------------
tests/kafkatest/tests/core/throttling_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/6b11fb7a/tests/kafkatest/tests/core/throttling_test.py
----------------------------------------------------------------------
diff --git a/tests/kafkatest/tests/core/throttling_test.py b/tests/kafkatest/tests/core/throttling_test.py
index a80af39..94a4010 100644
--- a/tests/kafkatest/tests/core/throttling_test.py
+++ b/tests/kafkatest/tests/core/throttling_test.py
@@ -133,7 +133,7 @@ class ThrottlingTest(ProduceConsumeValidateTest):
self.logger.debug("Transfer took %d second. Estimated time : %ds",
time_taken,
estimated_throttled_time)
- assert time_taken >= estimated_throttled_time, \
+ assert time_taken >= estimated_throttled_time * 0.9, \
("Expected rebalance to take at least %ds, but it took %ds" % (
estimated_throttled_time,
time_taken))