You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Anton Vinogradov (JIRA)" <ji...@apache.org> on 2016/07/26 10:06:20 UTC

[jira] [Comment Edited] (IGNITE-3323) Get rid of copypasted JB annotations, use dependency instead.

    [ https://issues.apache.org/jira/browse/IGNITE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393569#comment-15393569 ] 

Anton Vinogradov edited comment on IGNITE-3323 at 7/26/16 10:06 AM:
--------------------------------------------------------------------

Changes were merged to master, thanks a lot for your contribution!


was (Author: avinogradov):
Changes were merged to master, thanks a lot!

> Get rid of copypasted JB annotations, use dependency instead.
> -------------------------------------------------------------
>
>                 Key: IGNITE-3323
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3323
>             Project: Ignite
>          Issue Type: Task
>    Affects Versions: 1.5.0.final
>            Reporter: Anton Vinogradov
>            Assignee: Anton Vinogradov
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.7
>
>
> From user request: 
> {quote}
> I've come across an issue where there are a couple of classes duplicated from org.jetbrains.annotations within the ignite-core module which conflict with other part of our code base.
> As these files are duplicated rather than being referenced as a maven dependency I am unable to exclude them or reference a specific version of the org.jetbrains.annotations artifact.
> Specifically, the included version cannot be used to annotate types
> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE})
> annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})
> As far as I know there isn't an easy way of excluding these files from within the ignite-core module. Is there are reason why these "external" files have been duplicated within the ignite code base rather than being referenced as a maven dependency? Or alternatively, has anyone come across a way of avoiding these conflicts?
> {quote}
> Seems we have to remove these classes from Ignite code and use maven dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)