You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Shkvyra <ds...@hortonworks.com> on 2014/01/27 18:18:53 UTC
Review Request 17396: Expose server clock as top-level AMBARI_SERVER
attribute
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17396/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-4432
https://issues.apache.org/jira/browse/AMBARI-4432
Repository: ambari
Description
-------
Expose server clock via /api/v1/services/AMBARI/components/AMBARI_SERVER.
This should be in UNIX epoch time format (i.e., just a "long")
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 4c5320f
ambari-server/src/main/resources/properties.json 1e555c2
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java a49ad22
Diff: https://reviews.apache.org/r/17396/diff/
Testing
-------
Unitestst added. Tested at Centos 6.3/6.4
Thanks,
Dmytro Shkvyra
Re: Review Request 17396: Expose server clock as top-level AMBARI_SERVER
attribute
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17396/#review32847
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Jan. 27, 2014, 6:12 p.m., Dmytro Shkvyra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17396/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 6:12 p.m.)
>
>
> Review request for Ambari, Oleksandr Diachenko and Sid Wagle.
>
>
> Bugs: AMBARI-4432
> https://issues.apache.org/jira/browse/AMBARI-4432
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose server clock via /api/v1/services/AMBARI/components/AMBARI_SERVER.
> This should be in UNIX epoch time format (i.e., just a "long")
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 4c5320f
> ambari-server/src/main/resources/properties.json 1e555c2
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java a49ad22
>
> Diff: https://reviews.apache.org/r/17396/diff/
>
>
> Testing
> -------
>
> Unitestst added. Tested at Centos 6.3/6.4
>
>
> Thanks,
>
> Dmytro Shkvyra
>
>
Re: Review Request 17396: Expose server clock as top-level AMBARI_SERVER
attribute
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17396/#review32844
-----------------------------------------------------------
Ship it!
As well as we are adding clock to only server component, maybe we should cover with unit test case and ensure, that server clock is absent in response for agent component?
The rest LGTM, +1.
- Oleksandr Diachenko
On Jan. 27, 2014, 6:12 p.m., Dmytro Shkvyra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17396/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 6:12 p.m.)
>
>
> Review request for Ambari, Oleksandr Diachenko and Sid Wagle.
>
>
> Bugs: AMBARI-4432
> https://issues.apache.org/jira/browse/AMBARI-4432
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose server clock via /api/v1/services/AMBARI/components/AMBARI_SERVER.
> This should be in UNIX epoch time format (i.e., just a "long")
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 4c5320f
> ambari-server/src/main/resources/properties.json 1e555c2
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java a49ad22
>
> Diff: https://reviews.apache.org/r/17396/diff/
>
>
> Testing
> -------
>
> Unitestst added. Tested at Centos 6.3/6.4
>
>
> Thanks,
>
> Dmytro Shkvyra
>
>
Re: Review Request 17396: Expose server clock as top-level AMBARI_SERVER
attribute
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17396/
-----------------------------------------------------------
(Updated Feb. 7, 2014, 5:08 p.m.)
Review request for Ambari, Oleksandr Diachenko and Sid Wagle.
Changes
-------
See also test results:
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.server.controller.internal.RootServiceComponentResourceProviderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.156 sec
Bugs: AMBARI-4432
https://issues.apache.org/jira/browse/AMBARI-4432
Repository: ambari
Description
-------
Expose server clock via /api/v1/services/AMBARI/components/AMBARI_SERVER.
This should be in UNIX epoch time format (i.e., just a "long")
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 4c5320f
ambari-server/src/main/resources/properties.json 2cd5e35
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java a49ad22
Diff: https://reviews.apache.org/r/17396/diff/
Testing
-------
Unitestst added. Tested at Centos 6.3/6.4
Thanks,
Dmytro Shkvyra
Re: Review Request 17396: Expose server clock as top-level AMBARI_SERVER
attribute
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17396/
-----------------------------------------------------------
(Updated Feb. 7, 2014, 4:25 p.m.)
Review request for Ambari, Oleksandr Diachenko and Sid Wagle.
Changes
-------
Patch renewed.
Added test for case if componentName is not AMBARI_SERVER
Bugs: AMBARI-4432
https://issues.apache.org/jira/browse/AMBARI-4432
Repository: ambari
Description
-------
Expose server clock via /api/v1/services/AMBARI/components/AMBARI_SERVER.
This should be in UNIX epoch time format (i.e., just a "long")
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 4c5320f
ambari-server/src/main/resources/properties.json 2cd5e35
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java a49ad22
Diff: https://reviews.apache.org/r/17396/diff/
Testing
-------
Unitestst added. Tested at Centos 6.3/6.4
Thanks,
Dmytro Shkvyra
Re: Review Request 17396: Expose server clock as top-level AMBARI_SERVER
attribute
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17396/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 6:12 p.m.)
Review request for Ambari, Oleksandr Diachenko and Sid Wagle.
Changes
-------
Siddharth, please review patch
Bugs: AMBARI-4432
https://issues.apache.org/jira/browse/AMBARI-4432
Repository: ambari
Description
-------
Expose server clock via /api/v1/services/AMBARI/components/AMBARI_SERVER.
This should be in UNIX epoch time format (i.e., just a "long")
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 4c5320f
ambari-server/src/main/resources/properties.json 1e555c2
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java a49ad22
Diff: https://reviews.apache.org/r/17396/diff/
Testing
-------
Unitestst added. Tested at Centos 6.3/6.4
Thanks,
Dmytro Shkvyra
Re: Review Request 17396: Expose server clock as top-level AMBARI_SERVER
attribute
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17396/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 6:01 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Oleksandr Diachenko.
Changes
-------
Alex, please review patch because Dmitriy Lisnichenko said that this code area is not known for him
Bugs: AMBARI-4432
https://issues.apache.org/jira/browse/AMBARI-4432
Repository: ambari
Description
-------
Expose server clock via /api/v1/services/AMBARI/components/AMBARI_SERVER.
This should be in UNIX epoch time format (i.e., just a "long")
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java 4c5320f
ambari-server/src/main/resources/properties.json 1e555c2
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java a49ad22
Diff: https://reviews.apache.org/r/17396/diff/
Testing
-------
Unitestst added. Tested at Centos 6.3/6.4
Thanks,
Dmytro Shkvyra