[jira] Commented: (TRINIDAD-1415) allow :alias support to merge in -tr- custom skin properties as well

["Marius Petoi (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841274#action_12841274 ] 

Marius Petoi commented on TRINIDAD-1415:
----------------------------------------

Hi Jeanne,

What I did here is similar to the way in which aliases are included with "-tr-rule-ref". The styles are resolved in StyleSheetDocument, when they are necessary. I did the same way with the properties in the aliases. They are resolved also in StyleSheetDocument, when all "StyleSheetNode"-s are built. Therefore, for a StyleSheetDocument, the method getResolvedSkinProperties yields all the properties resolved; and afterwards this method is called from FileSystemStyleCache, so that when in a renderer we say getSkin().getProperty("af|foot-tr-my-property"), the value returned will be the resolved value of the property.

What you debugged is the parsing of the CSS file. And the value you got for the property is the correct one, as it is not resolved yet...it will be resolved when the actual property is needed.

Marius

> allow :alias support to merge in -tr- custom skin properties as well
> --------------------------------------------------------------------
>
>                 Key: TRINIDAD-1415
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1415
>             Project: MyFaces Trinidad
>          Issue Type: New Feature
>          Components: Skinning
>    Affects Versions:  1.2.11-core
>            Reporter: Jeanne Waldman
>         Attachments: 1415Reformatted.patch, tr_properties_in_alias.patch
>
>
> .AFSomeAlias:alias {-tr-my-property: red}
> af|foo {-tr-rule-ref: selector(".AFSomeAlias:alias")} 
> should resolve into:
> af|foo {-tr-my-property: red}
> so from the renderer you can say, getSkin().getProperty("af|foot-tr-my-property") and it would return red.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.