You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/14 20:33:27 UTC

[kudu-CR] CapturingLogAppender: synchronize access to captured log text 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14431

to review the following change.


Change subject: CapturingLogAppender: synchronize access to captured log text
......................................................................

CapturingLogAppender: synchronize access to captured log text

I have no explanation for how this could happen, but the test failure I'm
looking at speaks for itself:

  1) testSessionOnceClosed(org.apache.kudu.client.TestKuduClient)
  java.lang.StringIndexOutOfBoundsException: String index out of range: 419
	at java.lang.String.<init>(String.java:205)
	at java.lang.StringBuilder.toString(StringBuilder.java:407)
	at org.apache.kudu.test.CapturingLogAppender.getAppendedText(CapturingLogAppender.java:72)
	at org.apache.kudu.client.TestKuduClient.testSessionOnceClosed(TestKuduClient.java:1231)

Change-Id: I84a5d0775cba5aa1d9df5484b5e9e621c908d42d
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
2 files changed, 12 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/14431/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84a5d0775cba5aa1d9df5484b5e9e621c908d42d
Gerrit-Change-Number: 14431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] CapturingLogAppender: synchronize access to captured log text

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14431 )

Change subject: CapturingLogAppender: synchronize access to captured log text
......................................................................

CapturingLogAppender: synchronize access to captured log text

I have no explanation for how this could happen, but the test failure I'm
looking at speaks for itself:

  1) testSessionOnceClosed(org.apache.kudu.client.TestKuduClient)
  java.lang.StringIndexOutOfBoundsException: String index out of range: 419
	at java.lang.String.<init>(String.java:205)
	at java.lang.StringBuilder.toString(StringBuilder.java:407)
	at org.apache.kudu.test.CapturingLogAppender.getAppendedText(CapturingLogAppender.java:72)
	at org.apache.kudu.client.TestKuduClient.testSessionOnceClosed(TestKuduClient.java:1231)

Change-Id: I84a5d0775cba5aa1d9df5484b5e9e621c908d42d
Reviewed-on: http://gerrit.cloudera.org:8080/14431
Reviewed-by: Greg Solovyev <gs...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
2 files changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Greg Solovyev: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I84a5d0775cba5aa1d9df5484b5e9e621c908d42d
Gerrit-Change-Number: 14431
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] CapturingLogAppender: synchronize access to captured log text

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14431 )

Change subject: CapturingLogAppender: synchronize access to captured log text
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a5d0775cba5aa1d9df5484b5e9e621c908d42d
Gerrit-Change-Number: 14431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Oct 2019 03:53:19 +0000
Gerrit-HasComments: No

[kudu-CR] CapturingLogAppender: synchronize access to captured log text

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14431 )

Change subject: CapturingLogAppender: synchronize access to captured log text
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a5d0775cba5aa1d9df5484b5e9e621c908d42d
Gerrit-Change-Number: 14431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Oct 2019 20:47:52 +0000
Gerrit-HasComments: No