You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/05/13 00:08:25 UTC
Re: Review Request 19575: http auth for webui supported through libprocess
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19575/#review42752
-----------------------------------------------------------
3rdparty/libprocess/src/base64.cpp
<https://reviews.apache.org/r/19575/#comment76628>
please make this:
static const char chars[] = ".."
this avoids any static destruction order issues as string is non-POD.
- Dominic Hamon
On March 23, 2014, 11:40 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19575/
> -----------------------------------------------------------
>
> (Updated March 23, 2014, 11:40 p.m.)
>
>
> Review request for mesos, Adam B and Benjamin Hindman.
>
>
> Bugs: MESOS-1131
> https://issues.apache.org/jira/browse/MESOS-1131
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Draft of Http authentication tested for webui supported through libprocess.
> I used a Base64 code that I used in several projects but comes from cplusplus.com, I don't know if that raise a copyright question, in that case do you have any library suggestions?
> This review request is just a draft to know if I am heading in the right direction.
> Thank you in advance for your comments.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 3c6219e
> 3rdparty/libprocess/include/process/base64.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/http.hpp 7f549ba
> 3rdparty/libprocess/src/base64.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 6c6acc0
> 3rdparty/libprocess/src/tests/base64_tests.cpp PRE-CREATION
> src/master/main.cpp f12f20a
>
> Diff: https://reviews.apache.org/r/19575/diff/
>
>
> Testing
> -------
>
> Added a test for base64 and make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>