You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/04/15 11:36:01 UTC
[GitHub] [mynewt-core] vrahane opened a new pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
vrahane opened a new pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564
- nrf5340: Add support for enabling instruction/data cache in hal_system_init() based on syscfg and add dependencies for BUS_DRIVER
- nrf52xxx: Enable instruction code cache in hal_system_init() based on syscfg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820678141
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818752236
We can enable cache always but the problem with that is that sometimes the performance actually degrades instead of becoming better. It should be left to the developer to decide if he/she wants to enable it or not. Another thing is, if someone wants to monitor the performance of the cache, example: hit/miss counts, they would enable the cache and look at those registers, so, keeping it conditional is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820390986
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818402096
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818753199
@andrzej-kaczmarek yes agreed, will add a separate commit for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820390986
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-819147320
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818562723
why not just always enable icache than?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-819147320
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane merged pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig closed pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
utzig closed pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on a change in pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
vrahane commented on a change in pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#discussion_r614273425
##########
File path: hw/mcu/nordic/nrf5340/src/hal_system.c
##########
@@ -72,6 +81,7 @@ hal_debugger_connected(void)
void
hal_system_clock_start(void)
{
+
Review comment:
done
##########
File path: hw/mcu/nordic/nrf5340/src/hal_system.c
##########
@@ -36,6 +36,15 @@
void
hal_system_init(void)
{
+
Review comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818402096
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on a change in pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#discussion_r613983459
##########
File path: hw/mcu/nordic/nrf5340/src/hal_system.c
##########
@@ -72,6 +81,7 @@ hal_debugger_connected(void)
void
hal_system_clock_start(void)
{
+
Review comment:
nitpick
##########
File path: hw/mcu/nordic/nrf5340/src/hal_system.c
##########
@@ -36,6 +36,15 @@
void
hal_system_init(void)
{
+
Review comment:
why empty line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
utzig commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820352297
@vrahane The Travis fail on the branch is a bit weird, did you first push the branch upstream instead of to your own fork?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-819464465
@andrzej-kaczmarek added a separate commit for the BUS driver changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820353281
fair enough, two nitpicks though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
utzig commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820617171
> @utzig your are right, I did push to origin by mistake and then deleted it right after. The recent commits should fix that I guess.
Looks like it did, seems to require a rebase to sync with Travis again, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-818497959
split this into two separate PRs or at least do not mix unrelated bus driver and cache changes in single commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820616250
@utzig your are right, I did push to origin by mistake and then deleted it right after. The recent commits should fix that I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2564: nrf5340/nrf52xxx: Add support for enabling instruction/data cache in hal_system_init() and add dependencies for BUS DRIVER
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2564:
URL: https://github.com/apache/mynewt-core/pull/2564#issuecomment-820623728
@utzig done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org