You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/09/26 19:28:41 UTC
[Impala-ASF-CR] IMPALA-11614: Fix test metrics are zero for Ozone
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19044
Change subject: IMPALA-11614: Fix test_metrics_are_zero for Ozone
......................................................................
IMPALA-11614: Fix test_metrics_are_zero for Ozone
Fixes TestValidateMetrics.test_metrics_are_zero failure and avoids
incrementing the `num-missing-volume-id` metric for Ozone paths because
Ozone currently returns a list of nulls representing volume IDs.
Therefore the metric does not provide useful feedback with Ozone.
Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
---
M be/src/exec/hdfs-scan-node-base.cc
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/19044/1
--
To view, visit http://gerrit.cloudera.org:8080/19044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
Gerrit-Change-Number: 19044
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11614: Fix test metrics are zero for Ozone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19044 )
Change subject: IMPALA-11614: Fix test_metrics_are_zero for Ozone
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11447/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
Gerrit-Change-Number: 19044
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 19:49:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11614: Fix test metrics are zero for Ozone
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19044 )
Change subject: IMPALA-11614: Fix test_metrics_are_zero for Ozone
......................................................................
Patch Set 1: Code-Review+2
This makes sense to me
--
To view, visit http://gerrit.cloudera.org:8080/19044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
Gerrit-Change-Number: 19044
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 22:19:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11614: Fix test metrics are zero for Ozone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19044 )
Change subject: IMPALA-11614: Fix test_metrics_are_zero for Ozone
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8619/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
Gerrit-Change-Number: 19044
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 22:19:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11614: Fix test metrics are zero for Ozone
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19044 )
Change subject: IMPALA-11614: Fix test_metrics_are_zero for Ozone
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
Gerrit-Change-Number: 19044
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 03:24:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11614: Fix test metrics are zero for Ozone
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19044 )
Change subject: IMPALA-11614: Fix test_metrics_are_zero for Ozone
......................................................................
IMPALA-11614: Fix test_metrics_are_zero for Ozone
Fixes TestValidateMetrics.test_metrics_are_zero failure and avoids
incrementing the `num-missing-volume-id` metric for Ozone paths because
Ozone currently returns a list of nulls representing volume IDs.
Therefore the metric does not provide useful feedback with Ozone.
Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
Reviewed-on: http://gerrit.cloudera.org:8080/19044
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-scan-node-base.cc
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
Gerrit-Change-Number: 19044
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11614: Fix test metrics are zero for Ozone
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19044 )
Change subject: IMPALA-11614: Fix test_metrics_are_zero for Ozone
......................................................................
Patch Set 1:
Manually confirmed verifier passes after running E2E tests
verifiers/test_verify_metrics.py::TestValidateMetrics::test_metrics_are_zero <- ../../../../../../../data/jenkins/workspace/impala-private-ozone-parameterized/repos/Impala/tests/verifiers/test_verify_metrics.py PASSED
--
To view, visit http://gerrit.cloudera.org:8080/19044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0646063361185e04837a8c0fb2842fc4ce3f08f
Gerrit-Change-Number: 19044
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 22:15:54 +0000
Gerrit-HasComments: No