[GitHub] [pinot] klsince commented on a change in pull request #7319: Move offline seg download code to OfflineTableManager

[GitBox <gi...@apache.org>]

klsince commented on a change in pull request #7319:
URL: https://github.com/apache/pinot/pull/7319#discussion_r704588292



##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java
##########
@@ -146,4 +156,12 @@ void addSegment(String segmentName, TableConfig tableConfig, IndexLoadingConfig
    * @return List of {@link SegmentErrorInfo}
    */
   Map<String, SegmentErrorInfo> getSegmentErrors();
+
+  /**
+   * Get the dir for the given table segment, when TableDataManager object is not
+   * yet initialized for the given table.
+   */
+  static File getSegmentDataDir(String instanceDataDir, String tableNameWithType, String segmentName) {

Review comment:
       I was thinking to encapsulate the details of assembling the path to segment under table mgr iface. not feel strong about this though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org