You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/16 19:14:44 UTC

[GitHub] [arrow-rs] tfeda commented on a diff in pull request #1571: Replace &Option with Option<&T>

tfeda commented on code in PR #1571:
URL: https://github.com/apache/arrow-rs/pull/1571#discussion_r851661943


##########
parquet/src/file/metadata.rs:
##########
@@ -139,8 +139,8 @@ impl FileMetaData {
     /// ```shell
     /// parquet-mr version 1.8.0 (build 0fda28af84b9746396014ad6a415b90592a98b3b)
     /// ```
-    pub fn created_by(&self) -> &Option<String> {
-        &self.created_by
+    pub fn created_by(&self) -> Option<&String> {

Review Comment:
   Sure. I tried to keep as much of the api the same as possible, but if you'd like that changed I don't have a preference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org