You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/15 12:13:33 UTC

[GitHub] [arrow] jorgecarleitao opened a new pull request #8669: ARROW-10596: [Rust] Improve take benchmark

jorgecarleitao opened a new pull request #8669:
URL: https://github.com/apache/arrow/pull/8669


   This fixes 3 issues on the take benchmark:
   
   1. it is always taking the same element (indices is a constant vector), which is very easy to speculatively predict what the element is going to be.
   2. It also does not compare with vs without nulls
   3. all elements of the array are equal, which is again easy to speculatively predict
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao closed pull request #8669: ARROW-10596: [Rust] Improve take benchmark

Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #8669:
URL: https://github.com/apache/arrow/pull/8669


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8669: ARROW-10596: [Rust] Improve take benchmark

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8669:
URL: https://github.com/apache/arrow/pull/8669#issuecomment-727561941


   https://issues.apache.org/jira/browse/ARROW-10596


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] vertexclique commented on pull request #8669: ARROW-10596: [Rust] Improve take benchmark

Posted by GitBox <gi...@apache.org>.
vertexclique commented on pull request #8669:
URL: https://github.com/apache/arrow/pull/8669#issuecomment-727563881


   > it is always taking the same element (indices is a constant vector), which is very easy to speculatively predict what the element is going to be.
   
   Yes, most benchmarks do that. I think yet another pr solving this for most of them would be nice.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org