You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/14 20:33:55 UTC

[GitHub] zheng-da opened a new pull request #10116: Fix CuDNN performance after code refactor

zheng-da opened a new pull request #10116: Fix CuDNN performance after code refactor
URL: https://github.com/apache/incubator-mxnet/pull/10116
 
 
   ## Description ##
   This PR tries to fix the performance degradation report in https://github.com/apache/incubator-mxnet/issues/9874
   
   We observed about 4% performance decrease. There are multiple factors that cause the performance decrease.
   * The first one is that the refactored code passes more arrays to the backward of BatchNorm.
   * The second one is that the refactored code needs to reinitialize the CuDNN states in every forward and backward.
   * The third one is that the refactor code leads to more memory allocation (e.g., creating std::vector) in forward and backward. (However, the test shows that this doesn't cause much performance decrease.)
   
   This PR tries to reduce these overhead.
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services