You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "AnzhiZhang (via GitHub)" <gi...@apache.org> on 2025/08/13 01:18:06 UTC

[PR] fix: return when attribute type is not set in UDF [texera]

AnzhiZhang opened a new pull request, #3656:
URL: https://github.com/apache/texera/pull/3656

   fixes #3655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: return error when attribute type is not set in UDF [texera]

Posted by "seongjinyoon (via GitHub)" <gi...@apache.org>.
seongjinyoon commented on PR #3656:
URL: https://github.com/apache/texera/pull/3656#issuecomment-3182274555

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: return when attribute type is not set in UDF [texera]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3656:
URL: https://github.com/apache/texera/pull/3656#discussion_r2272063941


##########
core/workflow-core/src/main/scala/edu/uci/ics/amber/core/tuple/Attribute.java:
##########
@@ -45,12 +46,14 @@ public Attribute(
         this.attributeType = attributeType;
     }
 
-    @JsonProperty(value = "attributeName")
+    @JsonProperty(value = "attributeName", required = true)
+    @NotNull(message = "Attribute name is required")
     public String getName() {
         return attributeName;
     }
 
-    @JsonProperty(value = "attributeType")
+    @JsonProperty(value = "attributeType", required = true)
+    @NotNull(message = "Attribute name is required")

Review Comment:
   The error message is incorrect. This annotation is on the getType() method for attributeType, but the message says 'Attribute name is required'. It should be 'Attribute type is required'.
   ```suggestion
       @NotNull(message = "Attribute type is required")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: return error when attribute type is not set in UDF [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #3656:
URL: https://github.com/apache/texera/pull/3656


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org