You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Danijel Jevtic (JIRA)" <de...@myfaces.apache.org> on 2006/11/10 08:41:37 UTC

[jira] Created: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

DataScroller breaks facets functionality when using trinidad default renderkit
------------------------------------------------------------------------------

                 Key: TOMAHAWK-777
                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-777
             Project: MyFaces Tomahawk
          Issue Type: Bug
          Components: Data Scroller
    Affects Versions: 1.1.5-SNAPSHOT
         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
            Reporter: Danijel Jevtic
             Fix For: 1.1.5-SNAPSHOT


The trinidad renderkit seems to have some negative impact on the data scroller, 
because the images inside the facets are not rendered as links anymore.
This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.

Please, fix!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by Martin Marinschek <ma...@gmail.com>.
Nobody knows the troubles I have seen (with maven repositories)....

does no one have the time to look at this?

regards,

Martin

On 10/25/07, Piotr Steininger (JIRA) <de...@myfaces.apache.org> wrote:
>
>     [
> https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537607
> ]
>
> Piotr Steininger commented on TOMAHAWK-777:
> -------------------------------------------
>
> Bruno,
>
> Thanks for the quick update. I am using tomahawak via maven dependency.
> Currently the snapshot repo only has the binary distribution.
>
> Would you know approximately when this fix would be available in the
> snapshot binary ?
>
> Thank you again,
>
> Piotr
>
> > DataScroller breaks facets functionality when using trinidad default
> renderkit
> >
> ------------------------------------------------------------------------------
> >
> >                 Key: TOMAHAWK-777
> >                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
> >             Project: MyFaces Tomahawk
> >          Issue Type: Bug
> >          Components: Data Scroller
> >    Affects Versions: 1.1.5-SNAPSHOT
> >         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5
> Snapshot
> >            Reporter: Danijel Jevtic
> >            Assignee: Bruno Aranda
> >             Fix For: 1.1.7-SNAPSHOT
> >
> >         Attachments: patch10FacetDataScroller.patch
> >
> >
> > The trinidad renderkit seems to have some negative impact on the data
> scroller,
> > because the images inside the facets are not rendered as links anymore.
> > This breaks forward/backward/ff/fb/first/last functionality when using
> t:datatable and t:datascroller together with the trinidad components.
> > Please, fix!
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


-- 

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

[jira] Resolved: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Aranda resolved TOMAHAWK-777.
-----------------------------------

    Resolution: Fixed

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: patch10FacetDataScroller.patch
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Piotr Steininger (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537607 ] 

Piotr Steininger commented on TOMAHAWK-777:
-------------------------------------------

Bruno,

Thanks for the quick update. I am using tomahawak via maven dependency. Currently the snapshot repo only has the binary distribution.

Would you know approximately when this fix would be available in the snapshot binary ?

Thank you again,

Piotr

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: patch10FacetDataScroller.patch
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537532 ] 

Bruno Aranda commented on TOMAHAWK-777:
---------------------------------------

I have just applied the patch in the sources now, so if you want to get the fixed version now you should recompile from sources.

Thanks for the reminder,

Bruno

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: patch10FacetDataScroller.patch
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Piotr Steininger (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538775 ] 

Piotr Steininger commented on TOMAHAWK-777:
-------------------------------------------

I pointed the dependency in pom.xml to version 1.1.7-SNAPSHOT, but i still don't see the issues go away.

I believe I use this snapshot repo:
http://people.apache.org/maven-snapshot-repository/org/apache/myfaces/tomahawk/tomahawk/1.1.7-SNAPSHOT/

the dates on these files are from June 2007. Is this the most up-to-date repo?

Thanks,

Piotr

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: patch10FacetDataScroller.patch
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537634 ] 

Bruno Aranda commented on TOMAHAWK-777:
---------------------------------------

The snapshot has been deployed to the snapshots repo

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: patch10FacetDataScroller.patch
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516216 ] 

Martin Marinschek commented on TOMAHAWK-777:
--------------------------------------------

Even easier - we can just use a t:commandLink instead of an h:commandLink here, and then Trinidad won't play into this - Trinidad only replaces the h:commandLink renderer. So it is a very easy fix, I suspect - just change the component type when calling createComponent.

regards,

Martin

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Piotr Steininger (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538784 ] 

Piotr Steininger commented on TOMAHAWK-777:
-------------------------------------------

I also checked  http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/tomahawk/tomahawk/1.1.7-SNAPSHOT/

Everything was built on June 12, 2007, and I also see that there is no sources JAR

Bruno, could you look into this?

Thank you,

Piotr

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: patch10FacetDataScroller.patch
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516217 ] 

Bruno Aranda commented on TOMAHAWK-777:
---------------------------------------

Hi, if it works with the RI, feel free to change it... but there was not copy and paste either as the rendered link had a different implementation independent behaviour.

thanks,

Bruno

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Marinschek reopened TOMAHAWK-777:
----------------------------------------


Hmm... The fix is not really perfect - we are replicating the code out of the link renderer here. Can't we build up a small component tree or something and render it then? This smells a tad too much copy&paste to me.

regards,

Martin

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Aranda resolved TOMAHAWK-777.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.7-SNAPSHOT
         Assignee: Bruno Aranda

Fixed in the trunk for tomahawk

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit

Posted by "Piotr Steininger (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537417 ] 

Piotr Steininger commented on TOMAHAWK-777:
-------------------------------------------

Was this fix committed? I have this problem in an enterprise app for a Fortune 100 company.
I tried getting tomahawk-1.1.7-SNAPSHOT but the issue still isn't fixed

Thanks for an update

> DataScroller breaks facets functionality when using trinidad default renderkit
> ------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-777
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot
>            Reporter: Danijel Jevtic
>            Assignee: Bruno Aranda
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: patch10FacetDataScroller.patch
>
>
> The trinidad renderkit seems to have some negative impact on the data scroller, 
> because the images inside the facets are not rendered as links anymore.
> This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components.
> Please, fix!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.