You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/04 14:31:22 UTC

[GitHub] [arrow] rok commented on pull request #13462: ARROW-16932: [C++] Rounding RoundTemporalOptions.calendar_based_origin doesn't correctly offset non-UTC results

rok commented on PR #13462:
URL: https://github.com/apache/arrow/pull/13462#issuecomment-1173887911

   Thanks for the review @pitrou !
   
   > I'm unable to verify that the test values are ok, but the computational changes make sense.
   
   Correctness of logic and (by transitive relation) tests data will be checked against lubridate here #12154.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org