You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fanyon <gi...@git.apache.org> on 2017/05/10 08:15:38 UTC

[GitHub] flink pull request #3861: [Flink-6352] Support to use timestamp to set the i...

GitHub user fanyon opened a pull request:

    https://github.com/apache/flink/pull/3861

    [Flink-6352] Support to use timestamp to set the initial offset of kafka

    1. upgrade kafka version from 0.10.0.1 to 0.10.1.0
    2. add `setStartFromSpecificDate(Date)` method in `FlinkKafkaConsumerBase`
    3. support `setStartFromSpecificDate(Date)` in `FlinkKafkaConsumer010`
    4. add test case for `setStartFromSpecificDate(Date)`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fanyon/flink FLINK-6352

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3861
    
----
commit 3b0f093dd77e92f2d17756ccef90bb74a16da6b5
Author: mengji.fy <me...@taobao.com>
Date:   2017-05-10T03:40:08Z

    [FLINK-6352] support to use date to set the initial offset of kafka

commit 1a2fb226b454a0eb4c215176146f8d9b3222a099
Author: mengji.fy <me...@taobao.com>
Date:   2017-05-10T07:16:02Z

    update curr time check

commit 80d698c504c7e763a6c2f01f328991196dcafe05
Author: mengji.fy <me...@taobao.com>
Date:   2017-05-10T08:10:10Z

    fix first record lost when set the specific startup date

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3861: [Flink-6352] Support to use timestamp to set the initial ...

Posted by fanyon <gi...@git.apache.org>.

Github user fanyon commented on the issue:

    https://github.com/apache/flink/pull/3861
  
    @tzulitai @asfgit Could you please have a look at this PR when you are free, I'd look forward to hearing your minds, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3861: [Flink-6352] Support to use timestamp to set the initial ...

Posted by zjureel <gi...@git.apache.org>.

Github user zjureel commented on the issue:

    https://github.com/apache/flink/pull/3861
  
    Use [https://github.com/apache/flink/pull/3915](url) instead


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3861: [Flink-6352] Support to use timestamp to set the i...

Posted by fanyon <gi...@git.apache.org>.

Github user fanyon closed the pull request at:

    https://github.com/apache/flink/pull/3861


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3861: [Flink-6352] Support to use timestamp to set the initial ...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/3861
  
    Hi @zjureel, could you rebase your commits for the issue on the latest master?
    Otherwise I cannot review the PR like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---