You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@freemarker.apache.org by dd...@apache.org on 2020/08/01 23:02:15 UTC
[freemarker-docgen] 02/02: Made accurately tapping on mobile easier
at some parts
This is an automated email from the ASF dual-hosted git repository.
ddekany pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/freemarker-docgen.git
commit a3497de21c8175de82327cf439af4a7dfcd2fa88
Author: ddekany <dd...@apache.org>
AuthorDate: Sun Aug 2 01:01:48 2020 +0200
Made accurately tapping on mobile easier at some parts
---
.../docgen/core/less/lib/components/bookmarks.less | 6 +++++-
.../docgen/core/less/lib/components/breadcrumb.less | 6 +++++-
.../docgen/core/less/lib/components/page-menu.less | 5 +++++
.../org/freemarker/docgen/core/less/lib/layout/header.less | 14 ++++++++++----
.../org/freemarker/docgen/core/less/lib/utilities.less | 2 +-
5 files changed, 26 insertions(+), 7 deletions(-)
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/bookmarks.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/bookmarks.less
index 2c09b84..145116e 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/bookmarks.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/bookmarks.less
@@ -20,7 +20,11 @@
overflow: hidden;
white-space: nowrap;
- padding-top: @breadcrumb-row-padding-top;
+ @media (min-width: @screen-xs-min) {
+ // For smaller screens increased .breadcrumb-row line height will make up for this
+ padding-top: @breadcrumb-row-padding-top;
+ }
+
font-size: @breadcrumb-row-font-size-xs;
@media (min-width: @screen-xs-min) {
font-size: @breadcrumb-row-font-size-sm;
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/breadcrumb.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/breadcrumb.less
index 1d6495d..458a10b 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/breadcrumb.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/breadcrumb.less
@@ -17,7 +17,11 @@
* under the License.
*/
.breadcrumbs {
- padding-top: @breadcrumb-row-padding-top;
+ @media (min-width: @screen-xs-min) {
+ // For smaller screens increased .breadcrumb-row line height will make up for this
+ padding-top: @breadcrumb-row-padding-top;
+ }
+
// Right padding is the spacing between .breadcrumbs and .bookmarks (this works as overflow is hidden)
padding-right: 1.5em;
white-space: nowrap;
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/page-menu.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/page-menu.less
index 49a0602..7b55231 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/page-menu.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/page-menu.less
@@ -40,6 +40,11 @@
ul {
margin: 0 0 0 18px;
padding: 0;
+
+ line-height: 2.5;
+ @media (min-width: @screen-xs-min) {
+ line-height: 1.5;
+ }
}
a {
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/header.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/header.less
index 2a7cecd..6941237 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/header.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/header.less
@@ -91,18 +91,24 @@
}
.breadcrumb-row {
- padding-top: 9px; // increase padding when search row doesn't exist
+ // Mobile view:
+ padding-top: 6px;
+ // Non-mobile view:
+ @media (min-width: @screen-xs-min) {
+ padding-top: 0; // increase padding when search row doesn't exist
+ }
+
padding-bottom: 9px;
- .search-row + & {
- padding-top: 0;
- }
+ // Mobile view has small font here
+ line-height: 2.5;
@media (min-width: @screen-xs-min) {
display: flex;
justify-content: space-between;
flex-wrap: wrap;
align-items: flex-end;
+ line-height: 1.5;
}
}
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/utilities.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/utilities.less
index 84fa9f4..308b12c 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/utilities.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/utilities.less
@@ -18,7 +18,7 @@
*/
// determines the max-width of the site at various resolutions
.site-width {
- padding-left: @gutter-width / 4 * 3; // 18px
+ padding-left: @gutter-width / 4 * 3;
padding-right: @gutter-width / 4 * 3;
@media (min-width: @screen-sm-min) {