You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2026/08/26 15:08:01 UTC

(kafka) branch trunk updated: MINOR: Fix ProducerFailureHandlingTest configuration and topic creation (#23261)

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new ea8a27d6ee8 MINOR: Fix ProducerFailureHandlingTest configuration and topic creation (#23261)
ea8a27d6ee8 is described below

commit ea8a27d6ee88f7e447d207a59e635a0b160c1761
Author: YANG-SYUAN CHOU <di...@gmail.com>
AuthorDate: Wed Aug 26 23:07:54 2026 +0800

    MINOR: Fix ProducerFailureHandlingTest configuration and topic creation (#23261)
    
    This PR addresses follow-up comments from the review on #19319:
    
    https://github.com/apache/kafka/pull/19319#pullrequestreview-4996346537
    
    ### Changes
    
    - Use `REPLICA_FETCH_RESPONSE_MAX_BYTES_CONFIG` instead of the
    documentation constant when configuring
    `replica.fetch.response.max.bytes`.
    - Use `ClusterInstance#createTopic` when creating the group metadata
    topic so the test waits for topic creation rather than deletion.
    
    ### Testing
    
    ```bash
    ./gradlew clients:clients-integration-tests:test \
      --tests org.apache.kafka.clients.producer.ProducerFailureHandlingTest
    ```
    
    Reviewers: Ken Huang <s7...@gmail.com>, Chia-Ping Tsai
    <ch...@gmail.com>
---
 .../clients/producer/ProducerFailureHandlingTest.java     | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerFailureHandlingTest.java b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerFailureHandlingTest.java
index 4df1d0bb3b6..fc472b5d92d 100644
--- a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerFailureHandlingTest.java
+++ b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/producer/ProducerFailureHandlingTest.java
@@ -47,7 +47,7 @@ import static org.apache.kafka.clients.producer.ProducerConfig.RETRIES_CONFIG;
 import static org.apache.kafka.common.config.TopicConfig.MIN_IN_SYNC_REPLICAS_CONFIG;
 import static org.apache.kafka.coordinator.group.GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG;
 import static org.apache.kafka.server.config.ReplicationConfigs.REPLICA_FETCH_MAX_BYTES_CONFIG;
-import static org.apache.kafka.server.config.ReplicationConfigs.REPLICA_FETCH_RESPONSE_MAX_BYTES_DOC;
+import static org.apache.kafka.server.config.ReplicationConfigs.REPLICA_FETCH_RESPONSE_MAX_BYTES_CONFIG;
 import static org.apache.kafka.server.config.ServerConfigs.MESSAGE_MAX_BYTES_CONFIG;
 import static org.apache.kafka.server.config.ServerLogConfigs.AUTO_CREATE_TOPICS_ENABLE_CONFIG;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -68,7 +68,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
         //  15200 is filed replicaFetchMaxBytes
         @ClusterConfigProperty(key = REPLICA_FETCH_MAX_BYTES_CONFIG, value = "15200"),
         //  15400 is filed replicaFetchMaxResponseBytes
-        @ClusterConfigProperty(key = REPLICA_FETCH_RESPONSE_MAX_BYTES_DOC, value = "15400"),
+        @ClusterConfigProperty(key = REPLICA_FETCH_RESPONSE_MAX_BYTES_CONFIG, value = "15400"),
         // Set a smaller value for the number of partitions for the offset commit topic (__consumer_offset topic)
         // so that the creation of that topic/partition(s) and subsequent leader assignment doesn't take relatively long
         @ClusterConfigProperty(key = OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
@@ -217,13 +217,10 @@ public class ProducerFailureHandlingTest {
 
     @ClusterTest
     public void testCannotSendToInternalTopic(ClusterInstance clusterInstance) throws InterruptedException {
-        try (Admin admin = clusterInstance.admin()) {
-            Map<String, String> topicConfig = clusterInstance.brokers().get(0)
-                .groupCoordinator()
-                .groupMetadataTopicConfigs();
-            admin.createTopics(List.of(new NewTopic(Topic.GROUP_METADATA_TOPIC_NAME, 1, (short) 1).configs(topicConfig)));
-            clusterInstance.waitTopicDeletion(Topic.GROUP_METADATA_TOPIC_NAME);
-        }
+        Map<String, String> topicConfig = clusterInstance.brokers().get(0)
+            .groupCoordinator()
+            .groupMetadataTopicConfigs();
+        clusterInstance.createTopic(Topic.GROUP_METADATA_TOPIC_NAME, 1, (short) 1, topicConfig);
 
         try (Producer<byte[], byte[]> producer = clusterInstance.producer(producerConfig(1))) {
             Exception thrown = assertThrows(ExecutionException.class,