You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "MiniSho (via GitHub)" <gi...@apache.org> on 2023/07/04 12:50:15 UTC
[GitHub] [iotdb] MiniSho opened a new pull request, #10440: [IOTDB-6043] Pipe: Support wal hardlink
MiniSho opened a new pull request, #10440:
URL: https://github.com/apache/iotdb/pull/10440
1. add `wal` directory in `data/pipe` directory.
2. support wal hardlink, same as tsfile hardlink logic.
3. provide a Configuration item to control wal using hardlink or pin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #10440: [IOTDB-6043] Pipe: a framework to support wal hardlink mode
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu commented on PR #10440:
URL: https://github.com/apache/iotdb/pull/10440#issuecomment-1651226776
Please cherry-pick it to the rel/1.2 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a diff in pull request #10440: [IOTDB-6043] Pipe: Support wal hardlink
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu commented on code in PR #10440:
URL: https://github.com/apache/iotdb/pull/10440#discussion_r1252454540
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeInsertNodeTabletInsertionEvent.java:
##########
@@ -75,7 +76,13 @@ public InsertNode getInsertNode() throws WALPipeException {
@Override
public boolean internallyIncreaseResourceReferenceCount(String holderMessage) {
try {
- PipeResourceManager.wal().pin(walEntryHandler.getMemTableId(), walEntryHandler);
+ if (CommonDescriptor.getInstance().getConfig().getPipeWALEnableHardLink()) {
Review Comment:
Please use PipeConfig instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #10440: [IOTDB-6043] Pipe: a framework to support wal hardlink mode
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #10440:
URL: https://github.com/apache/iotdb/pull/10440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org