[GitHub] [kyuubi] dev-lpq commented on pull request #4698: [K8S][HELM] Centralize Kyuubi labels definition

["dev-lpq (via GitHub)" <gi...@apache.org>]

dev-lpq commented on PR #4698:
URL: https://github.com/apache/kyuubi/pull/4698#issuecomment-1509621334

   
   
   
   
   > Helm-generated
   
   
   
   > @dev-lpq BTW, [skywalking-kubernetes](https://github.com/apache/skywalking-kubernetes/tree/master/chart) charts have some problems/inconsistencies related to common labels:
   > 
   > * [adapter](https://github.com/apache/skywalking-kubernetes/tree/master/chart/adapter) has common labels defined in _helpers.tpl, but uses them in Deployment resource only.
   > * [operator](https://github.com/apache/skywalking-kubernetes/tree/master/chart/operator) also has common labels defined in _helpers.tpl, but uses them in Deployment resource only.
   > * [skywalking](https://github.com/apache/skywalking-kubernetes/tree/master/chart/skywalking) uses approach with explicitly defined labels (our current implementation).
   
   @dnskr  Thanks, I still think it's best to follow the Helm-generated label definitions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org