You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/04 03:14:59 UTC

[GitHub] [apisix-ingress-controller] zaunist commented on a diff in pull request #1213: feat: support docker-compose command detect

zaunist commented on code in PR #1213:
URL: https://github.com/apache/apisix-ingress-controller/pull/1213#discussion_r937309739


##########
test/e2e/testdata/wolf-rbac/cmd.sh:
##########
@@ -21,6 +21,11 @@ cd test/e2e/testdata/wolf-rbac/
 
 OPTION=$1
 
+if  ! command -v "docker-compose" > /dev/null; then
+	echo "docker-compose not found, please install docker-compose"

Review Comment:
   
   If so, we need to write both docker compose and docker-compose logic, which would be too cumbersome, and I noticed that docker compose is only integrated in docker desktop for Windows and Mac OS, not for Linux systems. 
   
    Ref https://github.com/docker/compose#windows-and-macos



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org