You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Ryan Wynn (JIRA)" <de...@myfaces.apache.org> on 2005/11/16 20:29:29 UTC
[jira] Created: (MYFACES-831) HtmlDataScrollerRenderer getLink methods creating duplicate HtmlCommandLinks
HtmlDataScrollerRenderer getLink methods creating duplicate HtmlCommandLinks
----------------------------------------------------------------------------
Key: MYFACES-831
URL: http://issues.apache.org/jira/browse/MYFACES-831
Project: MyFaces
Type: Bug
Components: Tomahawk
Versions: 1.1.1
Environment: Windows 2000, IE
Reporter: Ryan Wynn
The getLink methods in HtmlDataScrollerRenderer are called every time the HtmlDataScroller is rendered. The methods return a transient HtmlCommandLink. It looks like the transient property is not being honored because I am getting duplicate id exceptions for these links.
In order to patch it I extended HtmlDataScrollerRenderer and checked for the existence of the links. This seemed to work for me. But I still think it should have been ok as it was because the links are being set to transient.
In my extension of HtmlDataScrollerRenderer I added the following:
HtmlCommandLink link = (HtmlCommandLink) scroller.findComponent(scroller.getId() + facetName);
if (link == null) { // create link and link's children and add link to scroller .... }
return link;
The Faces view is being stored in the session. Not sure how transient property disallows Components to be stored in the session along with the view tree.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-86) HtmlDataScrollerRenderer getLink
methods creating duplicate HtmlCommandLinks
Posted by "Ryan Wynn (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-86?page=comments#action_12427759 ]
Ryan Wynn commented on TOMAHAWK-86:
-----------------------------------
I accidently created a new ticket for this with the patch attached. It is TOMAHAWK-596. TOMAHAWK-596 contains more description and the patch file. It should be considered to supercede this ticket.
> HtmlDataScrollerRenderer getLink methods creating duplicate HtmlCommandLinks
> ----------------------------------------------------------------------------
>
> Key: TOMAHAWK-86
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-86
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Data Scroller
> Environment: Windows 2000, IE
> Reporter: Ryan Wynn
> Assigned To: Thomas Spiegl
>
> The getLink methods in HtmlDataScrollerRenderer are called every time the HtmlDataScroller is rendered. The methods return a transient HtmlCommandLink. It looks like the transient property is not being honored because I am getting duplicate id exceptions for these links.
> In order to patch it I extended HtmlDataScrollerRenderer and checked for the existence of the links. This seemed to work for me. But I still think it should have been ok as it was because the links are being set to transient.
> In my extension of HtmlDataScrollerRenderer I added the following:
> HtmlCommandLink link = (HtmlCommandLink) scroller.findComponent(scroller.getId() + facetName);
> if (link == null) { // create link and link's children and add link to scroller .... }
> return link;
> The Faces view is being stored in the session. Not sure how transient property disallows Components to be stored in the session along with the view tree.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-86) HtmlDataScrollerRenderer getLink
methods creating duplicate HtmlCommandLinks
Posted by "MR (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-86?page=all ]
MR updated TOMAHAWK-86:
-----------------------
> HtmlDataScrollerRenderer getLink methods creating duplicate HtmlCommandLinks
> ----------------------------------------------------------------------------
>
> Key: TOMAHAWK-86
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-86
> Project: MyFaces Tomahawk
> Type: Bug
> Environment: Windows 2000, IE
> Reporter: Ryan Wynn
> Assignee: Thomas Spiegl
>
> The getLink methods in HtmlDataScrollerRenderer are called every time the HtmlDataScroller is rendered. The methods return a transient HtmlCommandLink. It looks like the transient property is not being honored because I am getting duplicate id exceptions for these links.
> In order to patch it I extended HtmlDataScrollerRenderer and checked for the existence of the links. This seemed to work for me. But I still think it should have been ok as it was because the links are being set to transient.
> In my extension of HtmlDataScrollerRenderer I added the following:
> HtmlCommandLink link = (HtmlCommandLink) scroller.findComponent(scroller.getId() + facetName);
> if (link == null) { // create link and link's children and add link to scroller .... }
> return link;
> The Faces view is being stored in the session. Not sure how transient property disallows Components to be stored in the session along with the view tree.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-831) HtmlDataScrollerRenderer getLink methods creating duplicate HtmlCommandLinks
Posted by "Ryan Wynn (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-831?page=comments#action_12357809 ]
Ryan Wynn commented on MYFACES-831:
-----------------------------------
If the fix ends up to be that existence of the link must be checked, this must be done in both variations of getLink.
> HtmlDataScrollerRenderer getLink methods creating duplicate HtmlCommandLinks
> ----------------------------------------------------------------------------
>
> Key: MYFACES-831
> URL: http://issues.apache.org/jira/browse/MYFACES-831
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: 1.1.1
> Environment: Windows 2000, IE
> Reporter: Ryan Wynn
>
> The getLink methods in HtmlDataScrollerRenderer are called every time the HtmlDataScroller is rendered. The methods return a transient HtmlCommandLink. It looks like the transient property is not being honored because I am getting duplicate id exceptions for these links.
> In order to patch it I extended HtmlDataScrollerRenderer and checked for the existence of the links. This seemed to work for me. But I still think it should have been ok as it was because the links are being set to transient.
> In my extension of HtmlDataScrollerRenderer I added the following:
> HtmlCommandLink link = (HtmlCommandLink) scroller.findComponent(scroller.getId() + facetName);
> if (link == null) { // create link and link's children and add link to scroller .... }
> return link;
> The Faces view is being stored in the session. Not sure how transient property disallows Components to be stored in the session along with the view tree.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-86) HtmlDataScrollerRenderer getLink
methods creating duplicate HtmlCommandLinks
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-86?page=comments#action_12376769 ]
Mike Kienenberger commented on TOMAHAWK-86:
-------------------------------------------
Ryan,
You mentioned you had a patch for this issue, but I don't see it.
> HtmlDataScrollerRenderer getLink methods creating duplicate HtmlCommandLinks
> ----------------------------------------------------------------------------
>
> Key: TOMAHAWK-86
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-86
> Project: MyFaces Tomahawk
> Type: Bug
> Components: Data Scroller
> Environment: Windows 2000, IE
> Reporter: Ryan Wynn
> Assignee: Thomas Spiegl
>
> The getLink methods in HtmlDataScrollerRenderer are called every time the HtmlDataScroller is rendered. The methods return a transient HtmlCommandLink. It looks like the transient property is not being honored because I am getting duplicate id exceptions for these links.
> In order to patch it I extended HtmlDataScrollerRenderer and checked for the existence of the links. This seemed to work for me. But I still think it should have been ok as it was because the links are being set to transient.
> In my extension of HtmlDataScrollerRenderer I added the following:
> HtmlCommandLink link = (HtmlCommandLink) scroller.findComponent(scroller.getId() + facetName);
> if (link == null) { // create link and link's children and add link to scroller .... }
> return link;
> The Faces view is being stored in the session. Not sure how transient property disallows Components to be stored in the session along with the view tree.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-86) HtmlDataScrollerRenderer getLink
methods creating duplicate HtmlCommandLinks
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-86?page=all ]
Mike Kienenberger updated TOMAHAWK-86:
--------------------------------------
Status: Open (was: Patch Available)
> HtmlDataScrollerRenderer getLink methods creating duplicate HtmlCommandLinks
> ----------------------------------------------------------------------------
>
> Key: TOMAHAWK-86
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-86
> Project: MyFaces Tomahawk
> Type: Bug
> Components: Data Scroller
> Environment: Windows 2000, IE
> Reporter: Ryan Wynn
> Assignee: Thomas Spiegl
>
> The getLink methods in HtmlDataScrollerRenderer are called every time the HtmlDataScroller is rendered. The methods return a transient HtmlCommandLink. It looks like the transient property is not being honored because I am getting duplicate id exceptions for these links.
> In order to patch it I extended HtmlDataScrollerRenderer and checked for the existence of the links. This seemed to work for me. But I still think it should have been ok as it was because the links are being set to transient.
> In my extension of HtmlDataScrollerRenderer I added the following:
> HtmlCommandLink link = (HtmlCommandLink) scroller.findComponent(scroller.getId() + facetName);
> if (link == null) { // create link and link's children and add link to scroller .... }
> return link;
> The Faces view is being stored in the session. Not sure how transient property disallows Components to be stored in the session along with the view tree.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira