[GitHub] jvrao commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

[GitBox <gi...@apache.org>]

jvrao commented on a change in pull request #742: Issue-744 BP-18 introduce write flags
URL: https://github.com/apache/bookkeeper/pull/742#discussion_r151913318
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java
 ##########
 @@ -0,0 +1,72 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+package org.apache.bookkeeper.client.api;
+
+import static com.google.common.base.Preconditions.checkArgument;
+
+import java.util.EnumSet;
+import lombok.Getter;
+
+/**
+ * Flags to specify the behaviour of writes
+ */
+@Getter
+public enum WriteFlag {
+
+    /**
+     * Writes will be ackknowledged by the server even if the entry
+     * has not been persisted durably.
+     */
+    DEFERRED_FORCE(0x1 << 0);
 
 Review comment:
   I think DEFERRED_SYNC may make more sense. I really don't know what FORCE means.
   Generally in Linux O_SYNC flag is what signifies persistence on return, here it is deferred. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services