You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/25 14:47:22 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4565: [Feature-#4549][remote]Rpc design
codecov-io commented on pull request #4565:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4565#issuecomment-766866517
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=h1) Report
> Merging [#4565](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=desc) (d1f4e6a) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/cfa88a4a804b3bc565f6571d5a6e842df18644a2?el=desc) (cfa88a4) will **increase** coverage by `0.44%`.
> The diff coverage is `69.95%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4565 +/- ##
============================================
+ Coverage 44.76% 45.21% +0.44%
- Complexity 3340 3438 +98
============================================
Files 527 552 +25
Lines 22815 23294 +479
Branches 2667 2693 +26
============================================
+ Hits 10214 10532 +318
- Misses 11680 11815 +135
- Partials 921 947 +26
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lphinscheduler/rpc/common/AbstractRpcCallBack.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NvbW1vbi9BYnN0cmFjdFJwY0NhbGxCYWNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../dolphinscheduler/rpc/common/RequestEventType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NvbW1vbi9SZXF1ZXN0RXZlbnRUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...dolphinscheduler/rpc/common/ResponseEventType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NvbW1vbi9SZXNwb25zZUV2ZW50VHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...olphinscheduler/rpc/remote/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL3JlbW90ZS9OZXR0eUNsaWVudEhhbmRsZXIuamF2YQ==) | `36.36% <36.36%> (ø)` | `6.00 <6.00> (?)` | |
| [.../apache/dolphinscheduler/rpc/future/RpcFuture.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2Z1dHVyZS9ScGNGdXR1cmUuamF2YQ==) | `58.33% <58.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...pache/dolphinscheduler/rpc/codec/NettyDecoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NvZGVjL05ldHR5RGVjb2Rlci5qYXZh) | `62.50% <62.50%> (ø)` | `2.00 <2.00> (?)` | |
| [...nscheduler/rpc/common/ConsumerConfigConstants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NvbW1vbi9Db25zdW1lckNvbmZpZ0NvbnN0YW50cy5qYXZh) | `66.66% <66.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...pache/dolphinscheduler/rpc/remote/NettyServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL3JlbW90ZS9OZXR0eVNlcnZlci5qYXZh) | `67.21% <67.21%> (ø)` | `5.00 <5.00> (?)` | |
| [...olphinscheduler/rpc/remote/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL3JlbW90ZS9OZXR0eVNlcnZlckhhbmRsZXIuamF2YQ==) | `67.44% <67.44%> (ø)` | `8.00 <8.00> (?)` | |
| [...pache/dolphinscheduler/rpc/common/RpcResponse.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcnBjL2NvbW1vbi9ScGNSZXNwb25zZS5qYXZh) | `76.92% <76.92%> (ø)` | `7.00 <7.00> (?)` | |
| ... and [50 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=footer). Last update [cfa88a4...d1f4e6a](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4565?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org