You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/30 15:24:25 UTC

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1162: fix: correct Version and GitHash output for manager-api command

nic-chen commented on a change in pull request #1162:
URL: https://github.com/apache/apisix-dashboard/pull/1162#discussion_r550231147



##########
File path: api/build.sh
##########
@@ -20,6 +20,7 @@ export ENV=local
 pwd=`pwd`
 
 VERSION=$(cat ./api/VERSION)
+GITHASH=$(git log --pretty=format:"%h" -1)

Review comment:
       > For the version released by apache, we add a new separate file to store the Git hash value.
   > 
   > Here is an example:
   > 
   > ```
   > $ cat ./.githash
   > bae2e05b
   > ```
   
   LGTM
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org