Re: [PR] [SPARK-49825][SQL] Fix the default warehouse dir for case with white spaces. [spark]

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #54794:
URL: https://github.com/apache/spark/pull/54794#discussion_r2937729067


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala:
##########
@@ -36,7 +36,7 @@ object StaticSQLConf {
     .doc("The default location for managed databases and tables.")
     .version("2.0.0")
     .stringConf
-    .createWithDefault(Utils.resolveURI("spark-warehouse").toString)
+    .createWithDefault(new File("spark-warehouse").getCanonicalFile.toString)

Review Comment:
   Hm, I think it might be an issue when HDFS scheme is default. `new File` will always pick the local file as `spark-warehouse`. `Utils.resolveURI("spark-warehouse").toString` will result in HDFS's current working directory if default scheme is set as HDFS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org