You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (Created) (JIRA)" <ji...@apache.org> on 2011/12/22 03:29:30 UTC
[jira] [Created] (HADOOP-7937) Forward port SequenceFile#syncFs and
friends from Hadoop 1.x
Forward port SequenceFile#syncFs and friends from Hadoop 1.x
------------------------------------------------------------
Key: HADOOP-7937
URL: https://issues.apache.org/jira/browse/HADOOP-7937
Project: Hadoop Common
Issue Type: New Feature
Components: io
Affects Versions: 0.22.0, 0.23.1
Reporter: Eli Collins
HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181934#comment-13181934 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #918 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/918/])
HADOOP-7937. Forward port SequenceFile#syncFs and friends from Hadoop 1.x.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228291
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7937) Forward port SequenceFile#syncFs and
friends from Hadoop 1.x
Posted by "Tom White (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-7937:
------------------------------
Resolution: Fixed
Fix Version/s: 0.22.1
Target Version/s: 0.22.0 (was: 0.23.1, 0.22.0)
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I just committed this to 0.22, 0.23 and trunk.
I see what you mean about reducing the visibility of the other methods in 1.x - really this should be done by applying the @Private annotations to the HDFS codebase (I think that the annotations are available in the 1 branch now at least).
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181460#comment-13181460 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1582 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1582/])
HADOOP-7937. Forward port SequenceFile#syncFs and friends from Hadoop 1.x.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228291
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181486#comment-13181486 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1529 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1529/])
HADOOP-7937. Forward port SequenceFile#syncFs and friends from Hadoop 1.x.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228291
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7937) Forward port SequenceFile#syncFs and
friends from Hadoop 1.x
Posted by "Tom White (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-7937:
------------------------------
Assignee: Tom White
Target Version/s: 0.22.0, 0.23.1 (was: 0.23.1, 0.22.0)
Status: Patch Available (was: Open)
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7937) Forward port SequenceFile#syncFs and
friends from Hadoop 1.x
Posted by "Tom White (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-7937:
------------------------------
Attachment: HADOOP-7937.patch
Here's a patch that adds the missing method to SequenceFile.Writer. No test is included (there isn't one in 1.0.0).
It's not clear that the other changes need to be ported, since the append implementation is different. If they do, they can be done in an HDFS JIRA.
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Labels: bigtop
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181469#comment-13181469 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #361 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/361/])
Merge -r 1228290:1228291 from trunk to branch-0.23. Fixes: HADOOP-7937
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228292
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181625#comment-13181625 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Common-22-branch #104 (See [https://builds.apache.org/job/Hadoop-Common-22-branch/104/])
Merge -r 1228290:1228291 from trunk to branch-0.22. Fixes: HADOOP-7937
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228295
Files :
* /hadoop/common/branches/branch-0.22/common/CHANGES.txt
* /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181926#comment-13181926 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #131 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/131/])
Merge -r 1228290:1228291 from trunk to branch-0.23. Fixes: HADOOP-7937
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228292
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181464#comment-13181464 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Common-0.23-Commit #350 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/350/])
Merge -r 1228290:1228291 from trunk to branch-0.23. Fixes: HADOOP-7937
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228292
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181954#comment-13181954 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #951 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/951/])
HADOOP-7937. Forward port SequenceFile#syncFs and friends from Hadoop 1.x.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228291
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Tom White (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180962#comment-13180962 ]
Tom White commented on HADOOP-7937:
-----------------------------------
The javac warning is because sync() is deprecated.
> Given that they're just used via DFSClient
Should DFSClient in trunk/23 use these methods, given that the append implementation is different to the one in 20? If so then that will need fixing in an HDFS JIRA.
I'll go ahead and commit this.
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181462#comment-13181462 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1509 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1509/])
HADOOP-7937. Forward port SequenceFile#syncFs and friends from Hadoop 1.x.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228291
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180857#comment-13180857 ]
Eli Collins commented on HADOOP-7937:
-------------------------------------
+1 (assuming the javac warning is unrelated, should be)
Looking at the other HDFS changes, agree that we probably don't need to forward port these. Given that they're just used via DFSClient, perhaps we should restrict the visibility in branch-1 to be more limited or javadoc that they won't be compatible?
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181471#comment-13181471 ]
Eli Collins commented on HADOOP-7937:
-------------------------------------
bq. I see what you mean about reducing the visibility of the other methods in 1.x - really this should be done by applying the @Private annotations to the HDFS codebase (I think that the annotations are available in the 1 branch now at least).
Cool, file a jira, link here and assign to me?
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180994#comment-13180994 ]
Eli Collins commented on HADOOP-7937:
-------------------------------------
bq. Should DFSClient in trunk/23 use these methods, given that the append implementation is different to the one in 20? If so then that will need fixing in an HDFS JIRA.
I don't think so, which is why I'm thinking we should reduce their visibility in branch-1 rather than forward port them to trunk. Make sense?
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181945#comment-13181945 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #153 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/153/])
Merge -r 1228290:1228291 from trunk to branch-0.23. Fixes: HADOOP-7937
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228292
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Fix For: 0.22.1
>
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179123#comment-13179123 ]
Hadoop QA commented on HADOOP-7937:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509348/HADOOP-7937.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 5 warning messages.
-1 javac. The applied patch generated 1044 javac compiler warnings (more than the trunk's current 1043 warnings).
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/494//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/494//console
This message is automatically generated.
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7937) Forward port SequenceFile#syncFs
and friends from Hadoop 1.x
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181458#comment-13181458 ]
Hudson commented on HADOOP-7937:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #340 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/340/])
Merge -r 1228290:1228291 from trunk to branch-0.23. Fixes: HADOOP-7937
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228292
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
> Forward port SequenceFile#syncFs and friends from Hadoop 1.x
> ------------------------------------------------------------
>
> Key: HADOOP-7937
> URL: https://issues.apache.org/jira/browse/HADOOP-7937
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0, 0.23.1
> Reporter: Eli Collins
> Assignee: Tom White
> Labels: bigtop
> Attachments: HADOOP-7937.patch
>
>
> HDFS-200 added a new public API SequenceFile#syncFs, we need to forward port this for compatibility. Looks like it might have introduced other APIs that need forward porting as well (eg LocaltedBlocks#setFileLength, and DataNode#getBlockInfo).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira