[jira] [Commented] (OAK-4924) avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565578#comment-15565578 ] 

Alex Parvulescu commented on OAK-4924:
--------------------------------------

if it's just about using EMPTY [0], instead of null, I don't see a problem with that.

[0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/commit/CommitInfo.java#L45

> avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh
> -------------------------------------------------------------------------
>
>                 Key: OAK-4924
>                 URL: https://issues.apache.org/jira/browse/OAK-4924
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>    Affects Versions: 1.5.12
>            Reporter: Stefan Egli
>             Fix For: 1.6
>
>
> Currently [SegmentNodeStore.refreshHead|https://github.com/apache/jackrabbit-oak/blob/d82f9b21d02a7eaf856f546e778118161d71b760/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStore.java#L231] calls {{contentChanged}} with null as the CommitInfo. This is problematic for prefiltering (OAK-4796, OAK-4907 et al) as for that a ChangeSet of changed items in a commit is stored in the CommitContext in the CommitInfo.
> Thus it would be useful to not send null but a CommitInfo that has the equivalent meaning of null but is a new object for each call (so that the ChangeSet can be set).
> [~mduerig], [~frm], [~alex.parvulescu] wdyt?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)