You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/02/09 20:48:06 UTC

[GitHub] [arrow] kou commented on a diff in pull request #34100: GH-34094: [C++] Increase Boost minimum version for clang >= 16

kou commented on code in PR #34100:
URL: https://github.com/apache/arrow/pull/34100#discussion_r1102006229


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1057,7 +1057,12 @@ macro(build_boost)
   set(BOOST_VENDORED TRUE)
 endmacro()
 
-if(ARROW_BUILD_TESTS)
+if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
+                                              VERSION_GREATER_EQUAL 16)

Review Comment:
   We can't use `VERSION_GREATER_EQUAL` for now because it's available since CMake 3.7:
   https://cmake.org/cmake/help/latest/command/if.html#version-greater-equal
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org