You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/12/16 15:21:27 UTC

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1458: MINIFICPP-1991 - Remove unused ControllerServiceProvider methods

martinzink commented on code in PR #1458:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1458#discussion_r1050869812


##########
libminifi/include/FlowController.h:
##########
@@ -225,11 +225,11 @@ class FlowController : public core::controller::ForwardingControllerServiceProvi
   // Whether it has already been initialized (load the flow XML already)
   std::atomic<bool> initialized_;
   // Flow Timer Scheduler

Review Comment:
   There are a lot of useless comments in FlowController.h and FlowController.cpp like this, could you please remove these while you are at it? :pleading_face:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org