[GitHub] [iceberg] kbendick commented on pull request #5228: [WIP] Build - Add Git Properties Information via Plugin

[GitBox <gi...@apache.org>]

kbendick commented on PR #5228:
URL: https://github.com/apache/iceberg/pull/5228#issuecomment-1179253108

   Example output of the `iceberg-version.properties` file from the tarball (after running `dev/source-release.sh`). I verified that the git SHA is the same as the one from the `version.txt` commit and that the tag is correct.
   
   I ran this as apache-iceberg-808-rc1, but via the `git.commit.message` and the `git.commit.describe` it can be verified that this information is correct.
   
   The only issue is that the tag will be from the final release candidate, not the actual release version. We can simply exclude that info or run a shell command over the file to remove the `rc` from inside `deploy.gradle`.
   
   I'd also like to remove some of the properties given that it leaks a lot of information about the build user etc (such as their email, which might not be the one used for the signing keys and might be hidden on github, etc).
   
   ```
   cat apache-iceberg-0.808/iceberg-version.properties
   git.branch=kb-gradle-git-properties-plugin-file-generation
   git.build.host=Kyles-MacBook-Pro-2.local
   git.build.user.email=kjbendickson@gmail.com
   git.build.user.name=Kyle Bendickson
   git.build.version=0.808
   git.closest.tag.commit.count=0
   git.closest.tag.name=apache-iceberg-0.808-rc1
   git.commit.id=e2aeac66dfdbbcf82a8dbc240e3908a02e0af637
   git.commit.id.abbrev=e2aeac6
   git.commit.id.describe=apache-iceberg-0.808-rc1
   git.commit.message.full=Add version.txt for release 0.808\n
   git.commit.message.short=Add version.txt for release 0.808
   git.commit.time=2022-07-08T11\:09\:02-0700
   git.commit.user.email=kjbendickson@gmail.com
   git.commit.user.name=Kyle Bendickson
   git.dirty=false
   git.remote.origin.url=git@github.com\:kbendick/iceberg.git
   git.tags=apache-iceberg-0.808-rc1
   git.total.commit.count=2937
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org